Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overly verbose alternative examples in README? #4

Open
gabrielgrant opened this issue Jun 21, 2016 · 1 comment
Open

Overly verbose alternative examples in README? #4

gabrielgrant opened this issue Jun 21, 2016 · 1 comment

Comments

@gabrielgrant
Copy link

Am I missing something, or could the alternative examples be simplified using Ember.computed.filterBy to just be:

// app/controllers/posts.js

export default Ember.Controller.extend({

  posts: Ember.computed(function() {
    return this.store.peekAll('post');
  }),

  filteredPosts: Ember.computed.filterBy('posts', 'isPublished')
});

and

// app/models/post.js

export default DS.Model.extend({

  comments: DS.hasMany('comment'),

  maintainedComments: Ember.computed.filterBy('comments', 'isDeleted', false);
  })
});
@pangratz
Copy link
Member

No, you are right 👍 Wanna open a PR to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants