Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply latest styleguide version #141

Open
6 tasks
jenweber opened this issue Nov 16, 2019 · 3 comments
Open
6 tasks

Apply latest styleguide version #141

jenweber opened this issue Nov 16, 2019 · 3 comments
Assignees

Comments

@jenweber
Copy link
Contributor

jenweber commented Nov 16, 2019

Things that need fixing:

  • buttons are too large and the styleguide size variations did not seem to work (note that we are using the link form of the button by applying classes to <a> (screenshot 1)
  • double ember logos look weird (screenshot 1)
  • Is it a design choice that cards do not have shadows? We kept the shadows, could tighten them up more
  • need some normalizing rules for tables, especially to make th not so bold
  • need an "active" state for the buttons
  • should use the small button style for "search" once it is fixed

Screen Shot 2019-11-16 at 2 45 55 PM

@vinodhrajamuralidharan
Copy link

I am on it

@jenweber
Copy link
Contributor Author

Hi @vinodhrajamuralidharan Thanks so much for the help! You can start your work from the website-redesign-rfc branch. The very first thing to do is to update the version of the styleguide to the latest release, in package.json. Then, see if things still look ok and what else needs fixing. The Styleguide has changed significantly since that branch was first created.

You can see the latest Styleguide docs here: https://deploy-preview-145--ember-styleguide.netlify.com/ This URL will disappear once ember-learn/ember-styleguide#145 is merged.

@MelSumner
Copy link
Member

@vinodhrajamuralidharan please DM me on Discord if you need help with anything- thank you for taking it on! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants