Self Closing tags

[tylerturdenpants]

One of the tests from https://github.com/ember-codemods/ember-angle-brackets-codemod/

Before ember-template-recast (correct)

input: {{some-component selected=(is-equal this.bar null)}}
output: <SomeComponent @selected={{is-equal this.bar null}} />

After ember-template-recast refactor (incorrect)

input: {{some-component selected=(is-equal this.bar null)}}
output: <SomeComponent @selected={{is-equal this.bar null}}></SomeComponent>

[rwjblue]

FWIW, we key the self closing tags off of selfClosing property on the ElementNode. Can you confirm that ember-angle-brackets-codemod sets that flag?

[tylerturdenpants]

I have since fix this on the codemod side.

[NullVoxPopuli]

no-implicit-this is encountering this issue -- I don't quite understand what's going on, cause ElementNode doesn't have a transform

  let paramTracker = {
    enter(node) {
      node.blockParams.forEach(param => {
        scopedParams.push(param);
      });
    },

    exit(node) {
      node.blockParams.forEach(() => {
        scopedParams.pop();
      });
    },
  };

  return {
    Program: paramTracker,
    ElementNode: paramTracker,
    // etc

@tylerturdenpants, how'd you solve this?
@rwjblue I did not find an occurrence of selfClosing in the angle-bracket codemod

[tylerturdenpants]

@NullVoxPopuli it’s on a PR for the recast refactor. ember-codemods/ember-angle-brackets-codemod#97