-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Cannot read properties of undefined (reading 'env')
after updating to 5.3.4 (extending @ember-data/store
)
#9483
Comments
I think this is a duplicate of #9461 |
thanks... i will try it later or next days to add build config... Docs found found on github: https://github.com/emberjs/data/tree/v5.3.4/packages/build-config#readme Looking at comment from other issue #9461 (comment) it seems that this change should be done without braking change... maybe it should be documented in changelogs (as it was a braking change in stable release)...
Edit: const { setConfig } = await import('@warp-drive/build-config');
setConfig(app, __dirname, {
___legacy_support: true
}); |
it’s not breaking if you use ember-data. You hit this because you’ve moved to using @ember-data/store directly, which is awesome but also occasionally will hit unexpected friction like this until ember-data is fully deprecated. |
I'm seeing something similar in an (in repo) (v1) addon going to 5.3.4
(mind the reading is not 'env'). Is that the same issue? In addition I don't think I'm using '@ember-data/store' directly other then an type import ( |
@basz thats a generic error thrown by ember-cli, there will be another error on the page somewhere |
not really unless I do https://gist.github.com/basz/bf611456463ab1819bc95ccae46f46e9 |
the gist doesn't seem to have any errors in it at all ... mind just outputing what the console gives you without |
it gets truncated when too long: https://gist.githubusercontent.com/basz/bf611456463ab1819bc95ccae46f46e9/raw/76366d9da7526e26bcab3c7855be166d443ad620/gistfile1.txt
|
aha, this is a different issue already fixed in the latest release. see #9498 |
Sure cause I've seen this now up until 5.3.7? |
@basz makes sense cause the fix was in 5.3.8 |
Lol! Great! |
After updating from 5.3.3 to 5.3.4 we are running in error
Cannot read properties of undefined (reading 'env')
.Bug can reproduced in this repo: https://github.com/mkszepp/ember-data-env-error
For repo there is only this code part necessary
When working directly on
ember-data/store
the error is not presentError:
The text was updated successfully, but these errors were encountered: