-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App styles leak into QUnit test runner UI #485
Comments
Thank you for reporting @broldak! I'm not 100% sure of the right solution here, but this is definitely quite annoying and we should try to figure out a good path forward. |
I addressed a similar problem with other styles leaking here qunitjs/qunit#1395 |
@rwjblue I don't think it fixes the specific issue, but could be used as inspiration for an approach to resolve their issue |
Perhaps a combination of CSS all and CSS unset or CSS revert could be of use here. I'd be open to accepting such a patch in QUnit upstream. |
Thanks @Krinkle! |
Been quite a while, but the behavior still persists it seems. Any news on the issue? |
@spuxx1701 Which QUnit version do you see in the browser when you encounter this issue? |
Because the test runner's UI and the UI of the rendered component/app are not isolated, the app styles leak into the QUnit test runner's UI. The example below shows a case where the inputs for Hide passed tests, Check for Globals, etc are rendered with no checkboxes due to some app styles.
Ideally QUnit's styles would not affect the rendered UI in the tests and vice versa.
The text was updated successfully, but these errors were encountered: