Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a specific commit of Heap-Layers #43

Open
ryandesign opened this issue Nov 2, 2018 · 1 comment
Open

Use a specific commit of Heap-Layers #43

ryandesign opened this issue Nov 2, 2018 · 1 comment
Assignees

Comments

@ryandesign
Copy link

Looks like Hoard's Makefile and GNUmakefile clone master of Heap-Layers. Unless you never change Heap-Layers, it seems likely that at some point you will introduce a change to Heap-Layers that will require a corresponding change to Hoard. When that happens, old versions of Hoard (which might be present in package management systems) will no longer be able to build. This problem might not always be noticed right away, leaving your software in broken state in that package management system for an unbounded period of time.

For this reason, you should download a specific version of Heap-Layers that is known to work with this version of Hoard.

I think git already behaved that way before when you were using submodules, so you could get this behavior back by reverting 5275686 and also making the same change to GNUmakefile.

@emeryberger
Copy link
Owner

Submodules have been a problem; people repeatedly fail to recursively clone and then wonder why Hoard won't build. It's a headache.

I could, however, checkout a specific version of Heap-Layers. Will that address this concern?

@emeryberger emeryberger self-assigned this Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants