Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot install apps consecutively from the store #120

Open
npentrel opened this issue Jun 9, 2024 · 3 comments · May be fixed by #167
Open

Cannot install apps consecutively from the store #120

npentrel opened this issue Jun 9, 2024 · 3 comments · May be fixed by #167
Assignees
@npentrel
Labels
bug Something isn't working

Comments

@npentrel
Copy link
Contributor

npentrel commented Jun 9, 2024

  1. Open app store
  2. Open StoreInstall
  3. Install an app
  4. Try to go back to StoreInstall (doesn't always work - can't press down sometimes)
  5. Try to select another app (doesn't work - can't press down)
@andypiper
Copy link
Contributor

Yes, I noticed the same thing - should this be logged on the app store repo? I guess that is the backend, and the on-badge code is here?

@npentrel
Copy link
Contributor Author

npentrel commented Jun 9, 2024

Reasonably sure it's a software issue. My guess is something with menus or handlers not being set correctly is my guess but I haven't looked into it

@npentrel npentrel added the bug Something isn't working label Jun 16, 2024
@Gregox273
Copy link
Contributor

Looking at app_store.py, it looks like the available_menu is cleaned up but not destroyed when selecting an app to install, so the button down event handler is removed during cleanup but then never re-registered.

Presumably the Menu instance in AppStoreApp.available_menu ought to be replaced when navigating back round? Or destroyed right after cleanup when an app is selected.

@npentrel npentrel linked a pull request Jun 22, 2024 that will close this issue
Open
@npentrel npentrel self-assigned this Jun 22, 2024
@npentrel npentrel mentioned this issue Jun 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npentrel npentrel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to install multiple apps npentrel/badge-2024-software
3 participants
@andypiper @npentrel @Gregox273