Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wayland dependencies are pulled in for eframe, even when wayland feature is disabled. #4538

Open
crumblingstatue opened this issue May 24, 2024 · 1 comment · May be fixed by #5478
Open

Wayland dependencies are pulled in for eframe, even when wayland feature is disabled. #4538

crumblingstatue opened this issue May 24, 2024 · 1 comment · May be fixed by #5478
Labels
bug Something is broken native-linux Problem specific to Linux

Comments

@crumblingstatue
Copy link
Contributor

crumblingstatue commented May 24, 2024 •
edited
Loading

Describe the bug
When depending on eframe with default features disabled, and only x11 and glow enabled, eframe is pulling in wayland dependencies.

To Reproduce
Create a new project, and depend on eframe with default features disabled.

[package]
name = "myeframetest"
version = "0.1.0"
edition = "2021"

[dependencies]
eframe = { git = "https://github.com/emilk/egui.git", default-features = false, features = ["glow", "x11"] }

Expected behavior

No wayland dependencies in Cargo.lock

What happens
Cargo.lock has several wayland dependencies.
@crumblingstatue crumblingstatue added the bug Something is broken label May 24, 2024
@crumblingstatue
Copy link
Contributor Author

These lines seem to be the culprits responsible:

diff --git a/Cargo.toml b/Cargo.toml
index a42033c0..3288d1c7 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -71,8 +71,8 @@ bytemuck = "1.7.2"
 criterion = { version = "0.5.1", default-features = false }
 document-features = " 0.2.8"
 glow = "0.13"
-glutin = "0.31"
-glutin-winit = "0.4"
+glutin = { version = "0.31", default-features = false }
+glutin-winit = { version = "0.4", default-features = false }
 image = { version = "0.25", default-features = false }
 log = { version = "0.4", features = ["std"] }
 nohash-hasher = "0.2"
diff --git a/crates/egui-winit/Cargo.toml b/crates/egui-winit/Cargo.toml
index 6354b7a4..6046e65e 100644
--- a/crates/egui-winit/Cargo.toml
+++ b/crates/egui-winit/Cargo.toml
@@ -40,7 +40,7 @@ bytemuck = ["egui/bytemuck"]
 
 ## Enable cut/copy/paste to OS clipboard.
 ## If disabled a clipboard will be simulated so you can still copy/paste within the egui app.
-clipboard = ["arboard", "smithay-clipboard"] # Unconditional dependency on smithay-clipboard
+clipboard = ["arboard"]
 
 ## Enable opening links in a browser when an egui hyperlink is clicked.
 links = ["webbrowser"]

@emilk emilk added the native-linux Problem specific to Linux label May 27, 2024
@xangelix xangelix linked a pull request Dec 15, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken native-linux Problem specific to Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unspecified wayland/x11 dep from clipboard feature xangelix/egui
2 participants
@emilk @crumblingstatue