Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs won't show if tab name is in Chinese #275

Open
xuchunyang opened this issue Feb 15, 2023 · 1 comment
Open

Tabs won't show if tab name is in Chinese #275

xuchunyang opened this issue Feb 15, 2023 · 1 comment

Comments

@xuchunyang
Copy link

e.g.,

        return [
            Tabs::make('Some Title', [
                Tab::make('基本信息', [
                    Text::make('Title'),
                ]),
                Tab::make('其他信息', [
                    Textarea::make('Content'),
                ]),
            ])
        ];

there is the result

CleanShot 2023-02-15 at 20 50 57@2x

note that tabs are missing. If I change the Chinese into English, it works fine.

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 19, 2023

This is a known issue. Slugs are generated by putting the name through Str::slug(), which strips out Chinese characters (among others, including Japanese, Korean and more).

I proposed a change to allow this to happen, but haven't had the time to implement it. See #249 for that.

Until then you're best off calling calling the name method on each tab and supplying a name using ASCII characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants