Add support for setting socket's blocking mode through ioctl with FIONBIO

Author: inolen

src/lib/libsockfs.js

@@ -421,6 +421,14 @@ addToLibrary({
             }
             {{{ makeSetValue('arg', '0', 'bytes', 'i32') }}};
             return 0;
+          case {{{ cDefs.FIONBIO }}}:
+            var on = {{{ makeGetValue('arg', '0', 'i32') }}};
+            if (on) {
+              sock.stream.flags |= {{{ cDefs.O_NONBLOCK }}};
+            } else {
+              sock.stream.flags &= ~{{{ cDefs.O_NONBLOCK }}};
+            }
+            return 0;
           default:
             return {{{ cDefs.EINVAL }}};
         }

src/lib/libsyscall.js

@@ -284,6 +284,7 @@ var SyscallsLibrary = {
         if (!stream.tty) return -{{{ cDefs.ENOTTY }}};
         return -{{{ cDefs.EINVAL }}}; // not supported
       }
+      case {{{ cDefs.FIONBIO }}}:
       case {{{ cDefs.FIONREAD }}}: {
         var argp = syscallGetVarargP();
         return FS.ioctl(stream, op, argp);

src/struct_info.json

@@ -312,6 +312,7 @@
     {
         "file": "bits/ioctl.h",
         "defines": [
+            "FIONBIO",
             "FIONREAD",
             "TCGETA",
             "TCGETS",

src/struct_info_generated.json

@@ -292,6 +292,7 @@
         "EWOULDBLOCK": 6,
         "EXDEV": 75,
         "EXFULL": 115,
+        "FIONBIO": 21537,
         "FIONREAD": 21531,
         "F_DUPFD": 0,
         "F_GETFD": 1,

src/struct_info_generated_wasm64.json

@@ -292,6 +292,7 @@
         "EWOULDBLOCK": 6,
         "EXDEV": 75,
         "EXFULL": 115,
+        "FIONBIO": 21537,
         "FIONREAD": 21531,
         "F_DUPFD": 0,
         "F_GETFD": 1,

test/sockets/test_sockets_echo_server.c

@@ -29,6 +29,15 @@ typedef int socklen_t;
 #include <emscripten.h>
 #endif
 
+#ifdef _WIN32
+typedef u_long ioctlarg_t;
+#else
+#define INVALID_SOCKET -1
+#define SOCKET_ERROR -1
+#define ioctlsocket ioctl
+typedef int ioctlarg_t;
+#endif
+
 #include "test_sockets_msg.h"
 
 typedef enum {
@@ -193,16 +202,16 @@ int main() {
 #else
   server.fd = socket(PF_INET, SOCK_DGRAM, IPPROTO_UDP);
 #endif
-  if (server.fd == -1) {
+  if (server.fd == INVALID_SOCKET) {
     perror("cannot create socket");
     exit(EXIT_FAILURE);
   }
-#ifdef _WIN32
-  unsigned long nonblocking = 1;
-  ioctlsocket(server.fd, FIONBIO, &nonblocking);
-#else
-  fcntl(server.fd, F_SETFL, O_NONBLOCK);
-#endif
+
+  ioctlarg_t on = 1;
+  if (ioctlsocket(server.fd, FIONBIO, &nonblocking) == SOCKET_ERROR) {
+    perror("ioctlsocket failed");
+    exit(EXIT_FAILURE);
+  }
 
   memset(&addr, 0, sizeof(addr));
   addr.sin_family = AF_INET;
@@ -213,14 +222,14 @@ int main() {
   }
 
   res = bind(server.fd, (struct sockaddr *)&addr, sizeof(addr));
-  if (res == -1) {
+  if (res == SOCKET_ERROR) {
     perror("bind failed");
     exit(EXIT_FAILURE);
   }
 
 #if !TEST_DGRAM
   res = listen(server.fd, 50);
-  if (res == -1) {
+  if (res == SOCKET_ERROR) {
     perror("listen failed");
     exit(EXIT_FAILURE);
   }