-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable/disable system services and settings via API #2182
Comments
Request to extend this to turn LED on and off as well |
If i understand right, the appoach with |
This is a good approach. My idea was to originally move I would only keep things simple and have the showertimer as this makes it easier for the end user. and keep to on/off, so remove txmode. Changing that real-time can be dangerous. |
I think the commands should always be the same as api read of the entity. E.g.
So the command also has to be
ot sure, as i implemented the shower settings without prefix the user extected them as |
okay, that actually makes a lot of sense. What do you want me to do next, test? |
The doc also needs to be updated. |
fix link to issue emsesp#2182
Triggered by #2168 two new commands were added in 3.7.1 to control the shower (
/api/system/showeralert
and/api/system/showertimer
).A more generic approach is to extend the new
action
command, moving this from /rest/ to a HTTP POST API/api/system
so we can use a format like {"action":'enable|disable', param:'ntp|ap|syslog|showeralert...'}.`This will remove 3 EMS-ESP Commands and free up some memory.
The text was updated successfully, but these errors were encountered: