Added dae/stl fallback from cli (obj default now) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added stl & obj files to meshes, updated xacro files to build a specific file type using arg:mesh:=mesh_type (defaulted to dae)
Contributor
|
Thank you for your helpful PR. But we want to use the obj file as the default visual . |
ANonABento
changed the title
Author
|
Swapped default parameters to obj 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most file changes are just adding stl and obj versions of every mesh.
Now your able to change file type by adding "mesh:=obj" to launch command.
Colors are off, unsure how to fix.