We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, unsubscribing from one Kafka channel unsubscribes from all channels. Based on the aiokafka docs I'm guessing we want to do
self._consumer_channels.remove(channel) self._consumer.subscribe(topics=self._consumer_channels)
The text was updated successfully, but these errors were encountered:
Also, when we call AIOKafkaConsumer we might want to add auto_offset_reset="latest" based on https://aiokafka.readthedocs.io/en/stable/consumer.html#controlling-the-consumer-s-position. Even then, when we change the topics we're subscribed to it's not obvious to me that we won't miss events or process events multiple times.
AIOKafkaConsumer
auto_offset_reset="latest"
Sorry, something went wrong.
Why didn't merge this PR?
Currently, unsubscribing from one Kafka channel unsubscribes from all channels. Based on the aiokafka docs I'm guessing we want to do self._consumer_channels.remove(channel) self._consumer.subscribe(topics=self._consumer_channels)
When _counsumer_channels will be empty it raise error, so:
async def unsubscribe(self, channel: str) -> None: self._consumer_channels.remove(channel) if self._consumer_channels: self._consumer.subscribe(topics=list(self._consumer_channels)) else: self._consumer.unsubscribe()
No branches or pull requests
Currently, unsubscribing from one Kafka channel unsubscribes from all channels. Based on the aiokafka docs I'm guessing we want to do
The text was updated successfully, but these errors were encountered: