Local static functions are missing from diff

[Francessco121]

In the Dinosaur Planet decomp we have DLL code that makes heavy use of static functions which must be static in order to match calling code. These are missing from objdiff as it ignores local symbols with a size of zero: https://github.com/encounter/objdiff/blob/v2.7.1/objdiff-core/src/obj/read.rs#L170-L176. Removing this code fixes the issue but I imagine also breaks other projects.

I don't totally understand why these symbols have a size of zero but if it helps the compiler is IDO 5.3.

readelf symbol table output
(num, value, size, type, bind, vis, ndx, name):

Missing functions in UI (CLI can't diff them either, just says it cant find the symbol):

[encounter]

Fixed in v3.0.0-alpha.1

[Francessco121]

Unfortunately, this didn't fully fix the issue. Not sure if this is a different problem or related.
Static functions show up now:

But the diff is just the first instruction repeated:

Non-statics work fine

[encounter]

How weird! Do you have objects I can reproduce with?

[Francessco121]

Yeah,
flash.zip

(had to zip it for GitHub, its just the one .o file inside)

I can try to do my own debugging soon as well and make sure its not something screwy with our setup. Tho I've had no issues with the previous objdiff version with those few lines removed that I mentioned in the original comment.

[encounter]

It’s definitely a regression in v3 alpha, I just got another report about it. Will fix asap

[Francessco121]

Works perfect now, thanks! ❤