Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make warnings as errors apply only to release builds #18

Open
idg10 opened this issue Jul 9, 2020 · 0 comments
Open

Make warnings as errors apply only to release builds #18

idg10 opened this issue Jul 9, 2020 · 0 comments
Assignees

Comments

@idg10
Copy link
Contributor

idg10 commented Jul 9, 2020

We handle warnings as errors to enforce the requirement that we don't check in code that produces warnings. However, this has a negative impact on the developer inner loop. Making small tweaks to code during experimentation becomes much more onerous because you often end up needing to make a bunch of extra changes to keep stylecop and other analyzers happy, for code you may well end up discarding.

To deal with this, we will change to treating warnings as errors only on for release builds. This will continue to prevent code with warnings from being merged in—if developers push code that produces warnings, these will become errors in the CI builds, which will then block the relevant PR from being merged. But it will enable developers to work with warnings during development, fixing them later on as experimentation gives way to writing the final code.

@idg10 idg10 self-assigned this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant