Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider writing our own GitHub detection task #33

Open
idg10 opened this issue Jan 18, 2022 · 1 comment
Open

Consider writing our own GitHub detection task #33

idg10 opened this issue Jan 18, 2022 · 1 comment

Comments

@idg10
Copy link
Contributor

idg10 commented Jan 18, 2022

We currently depend on Microsoft.Build.Tasks.Git to discover things about the git repo. Unfortunately, it turns out to be impossible to use this in a way that does report a warning if you're not in a Git repo.

So we had to add a horrible hack to detect whether we think we're in a Git repo before using that component. At some stage we might want to look at the following options

  • asking nicely whether we could add something to Microsoft.Build.Tasks.Git to suppress that warning
  • writing our own custom task DLL so we don't depend on that external component, and can just do exactly what we want
@MikeEvansLarah
Copy link
Contributor

As part of this we could also consider warning people that they are not working in a Git initialized repo (e.g. "you have been working in here for 4 days, should you be using Git?")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants