Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tame Promise.all for causal tracing #1568

Open
kriskowal opened this issue Apr 30, 2023 · 1 comment
Open

Tame Promise.all for causal tracing #1568

kriskowal opened this issue Apr 30, 2023 · 1 comment
Labels
kriskowal-reviewed-2024-01 Issues that kriskowal is satisfied do not need attention from team bug review as of January, 2024

Comments

@kriskowal
Copy link
Member

Promise.all does not currently participate in our causal graph construction with assert.note. We could wrap Promise.all to that effect.

@mhofman
Copy link
Contributor

mhofman commented May 2, 2023

Would this wrap a rejection in promise.all to the capture the caller? I hope that someday we can have a more holistic approach to this problem that patching some APIs. Maybe AsyncContext can help somehow, but I'm not sure it can given the current API.

Also to clarify, this would keep the semantics of short circuiting on rejections? We should similarly find a way to annotate unhandled rejections for the potential rejections that arrive after a short circuit. (I also want my PromiseAllOrRejections helper moved to endo to avoid writing code that causes unhandled rejections on short circuiting)

@kriskowal kriskowal added the kriskowal-reviewed-2024-01 Issues that kriskowal is satisfied do not need attention from team bug review as of January, 2024 label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kriskowal-reviewed-2024-01 Issues that kriskowal is satisfied do not need attention from team bug review as of January, 2024
Projects
None yet
Development

No branches or pull requests

2 participants