Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify more platforms and externalize environment checking #71

Closed
wants to merge 26 commits into from
Closed

Identify more platforms and externalize environment checking #71

wants to merge 26 commits into from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 18, 2022 •
edited
Loading

Hi @radu-matei , this PR includes the npm audit fix.
Please merge it first so the other PR won't fail.

  1. This PR externalizes the environment checking in a dedicated file.

The checking consist in :

  • ensure that the required environment variables are available
  • ensure that docker is available
  • ensure that the request version of Kind supports the current platform
  • print a warning if setup-kind doesn't support the current platform
  • print a warning if the image doesn't include a sha256

  1. Kubectl is now installed with the right version when kubernetes version can be identified throught the provided image or the kind config file

  2. A metallb load-balancer can be installed with loadBalancer : true

  3. A local registry can be installed with localRegistry : true

NB : latest can be a valid value for the kind version input parameter

closes #9
closes #16
closes #81

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022 •
edited
Loading

Codecov Report

Merging #71 (5c5bbdf) into master (eb0371b) will decrease coverage by 14.87%.
The diff coverage is 34.56%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #71       +/-   ##
===========================================
- Coverage   62.81%   47.94%   -14.88%     
===========================================
  Files           6       10        +4     
  Lines         199      340      +141     
  Branches       34       53       +19     
===========================================
+ Hits          125      163       +38     
- Misses         70      171      +101     
- Partials        4        6        +2
Impacted Files Coverage Δ
src/requirements.ts 14.14% <14.14%> (ø)
src/go.ts 29.41% <16.66%> (-3.93%) ⬇️
src/kind/post.ts 63.33% <40.00%> (-3.91%) ⬇️
src/local-registry.ts 42.00% <42.00%> (ø)
src/kubectl.ts 50.00% <50.00%> (ø)
src/yaml/helper.ts 50.00% <50.00%> (ø)
src/kind/main.ts 78.37% <57.14%> (+9.62%) ⬆️
src/docker.ts 66.66% <66.66%> (ø)
src/constants.ts 96.96% <90.90%> (-3.04%) ⬇️
src/kind/core.ts 75.00% <100.00%> (+15.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0371b...5c5bbdf. Read the comment docs.

@mmorel-35 mmorel-35 changed the title define endianness const Identify Solaris platform, 386 and amd architectures Jan 22, 2022
@mmorel-35 mmorel-35 changed the title Identify Solaris platform, 386 and amd architectures Identify Solaris goos, 386 and amd goarch Jan 22, 2022
@mmorel-35 mmorel-35 changed the title Identify Solaris goos, 386 and amd goarch Identify Solaris goos, 386, mipsle and amd goarch Jan 22, 2022
@mmorel-35 mmorel-35 changed the title Identify Solaris goos, 386, mipsle and amd goarch Identify more platforms and externalize environnement Jan 25, 2022
@mmorel-35 mmorel-35 changed the title Identify more platforms and externalize environnement Identify more platforms and externalize environnement checking Jan 25, 2022
@mmorel-35 mmorel-35 changed the title Identify more platforms and externalize environnement checking Identify more platforms and externalize environment checking Jan 25, 2022
@mmorel-35 mmorel-35 marked this pull request as draft February 9, 2022 17:21
@mmorel-35 mmorel-35 marked this pull request as ready for review February 9, 2022 17:53
@mmorel-35 mmorel-35 mentioned this pull request Feb 11, 2022
Open
@mmorel-35 mmorel-35 marked this pull request as draft February 18, 2022 11:25
@mmorel-35 mmorel-35 marked this pull request as ready for review February 18, 2022 18:08
@mmorel-35 mmorel-35 marked this pull request as draft February 24, 2022 20:36
@mmorel-35 mmorel-35 marked this pull request as ready for review February 24, 2022 20:36
@mmorel-35 mmorel-35 marked this pull request as draft February 24, 2022 20:36
@mmorel-35 mmorel-35 marked this pull request as ready for review February 24, 2022 20:37
@mmorel-35 mmorel-35 marked this pull request as draft February 24, 2022 20:37
@mmorel-35 mmorel-35 marked this pull request as ready for review February 24, 2022 20:37
@mmorel-35
Copy link
Contributor Author

Please @radu-matei , when do you think you'll find the time to review this ?
Thank you!

@mmorel-35 mmorel-35 closed this Aug 29, 2022
@mmorel-35 mmorel-35 deleted the patch-3 branch August 29, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document running on self-hosted agents How do I update kubectl?
2 participants
@mmorel-35 @codecov-commenter