Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs 404 is missing #207

Closed
ryanbethel opened this issue Apr 4, 2024 · 3 comments
Closed

Docs 404 is missing #207

ryanbethel opened this issue Apr 4, 2024 · 3 comments
Assignees

Comments

@ryanbethel
Copy link
Contributor

Missing pages inside docs don't have a 404 page (i.e. https://enhance.dev/docs/lost ).

@macdonst
Copy link
Contributor

macdonst commented Jun 3, 2024

We'd have to ask @colepeters what this code's purpose is as it breaks the above 404 redirect.

https://github.com/enhance-dev/enhance.dev/blob/main/app/api/docs/%24%24.mjs#L67

@colepeters
Copy link
Member

Great question. This code predates me though so I'm not totally sure myself 😅

Perhaps one for @tbeseda if not you, Simon? ;)

image

@macdonst
Copy link
Contributor

macdonst commented Jun 4, 2024

@colepeters OMG, this is from the first commit of enhance.dev. Probably worked once upon a time but as the site evolved the bug showed up. I'll take this on.

@macdonst macdonst self-assigned this Jun 4, 2024
macdonst added a commit that referenced this issue Jun 4, 2024
macdonst added a commit that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants