devop: update zerox api #615
Conversation
[FIX] Asset Balances Not Showing for Rootstock
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughChanges span multiple packages, updating dependency and devDependency versions across numerous package.json files. Notable updates include version bumps for tools like commitlint, swc, eslint, typescript, and many others. Minor syntax improvements, such as added semicolons, enhance code consistency in TypeScript and Vue files. In wallet-related modules, the Wallet import is revised to a named import while the method for retrieving wallet addresses is switched to a dedicated function. Configuration files have been updated with expanded file inclusions, new alias mappings, revised legacy and polyfill settings, and external dependency definitions. Additionally, the ZeroX API endpoint URL has been updated. Changes
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
💼 Build Files |
…t into devop/update-zerox-api
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (22)
package.json(1 hunks)packages/extension-bridge/package.json(1 hunks)packages/extension/configs/vite/transform-manifest.ts(3 hunks)packages/extension/package.json(3 hunks)packages/extension/src/ui/action/main.ts(1 hunks)packages/extension/src/ui/action/views/import-account/views/import-account-password.vue(2 hunks)packages/extension/src/ui/action/views/import-account/views/import-account-private-key.vue(2 hunks)packages/extension/tsconfig.node.json(1 hunks)packages/extension/vite.config.ts(3 hunks)packages/hw-wallets/package.json(2 hunks)packages/keyring/package.json(1 hunks)packages/name-resolution/package.json(2 hunks)packages/request/package.json(1 hunks)packages/signers/bitcoin/package.json(1 hunks)packages/signers/ethereum/package.json(1 hunks)packages/signers/kadena/package.json(1 hunks)packages/signers/polkadot/package.json(1 hunks)packages/storage/package.json(1 hunks)packages/swap/package.json(1 hunks)packages/swap/src/providers/zerox/index.ts(2 hunks)packages/types/package.json(1 hunks)packages/utils/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- packages/extension/src/ui/action/main.ts
- packages/swap/src/providers/zerox/index.ts
- packages/extension/configs/vite/transform-manifest.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: buildAll
- GitHub Check: test
🔇 Additional comments (32)
packages/extension/vite.config.ts (2)
73-73: LGTM: OS module polyfill added.Adding 'os' to the nodePolyfills include list is appropriate for browser compatibility.
104-104: LGTM: Externalized fs module.Marking 'fs' as external is correct as it's a Node.js module that shouldn't be bundled for browser use.
packages/extension/src/ui/action/views/import-account/views/import-account-password.vue (2)
40-40: LGTM: Updated to @ethereumjs/wallet package.The import statement has been correctly updated to use the new package name and named imports.
116-116: LGTM: Simplified address retrieval.Using
getAddressString()is a cleaner approach than the previous method.packages/extension/src/ui/action/views/import-account/views/import-account-private-key.vue (2)
39-39: LGTM: Consistent package update.The import statement has been updated consistently with other files.
96-96: LGTM: Consistent method usage.The address retrieval method has been updated to match the changes in other files.
packages/extension/tsconfig.node.json (2)
14-16: LGTM: Enhanced TypeScript coverage.Added patterns ensure proper TypeScript checking for source and config files.
25-28: LGTM: Path aliases match usage.The path aliases correctly match the import patterns used in the Vue components.
packages/types/package.json (1)
27-41: Dependency Version Updates in DevDependencies
The updated versions for@types/node,eslint,prettier,tsup,typescript, andtypescript-eslintare applied correctly. They align with the project-wide bumps seen in related packages. Please ensure that these new versions have been thoroughly tested in your CI to avoid any compatibility hiccups.packages/storage/package.json (1)
30-45: Consistent DevDependency Bumps
The devDependencies section now updates@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitestto their newer versions. These changes are consistent with the updates in other packages. No issues spotted; just confirm integration tests cover any edge cases that could be affected by these version bumps.packages/name-resolution/package.json (1)
25-40: Harmonized DevDependencies Version Updates
The version updates for packages such as@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitestensure consistency with the overall repository. Additionally, the bump in@unstoppabledomains/resolutionto^9.3.3should be verified against any related integration points for domain resolution.packages/signers/kadena/package.json (1)
31-48: Updated DevDependencies Including External Crypto Library
The updated versions for@polkadot/util-crypto,@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitestin the devDependencies are correctly applied. Make sure the bump in@polkadot/util-cryptoto^13.3.1is fully compatible with the existing Kadena signing logic.packages/utils/package.json (2)
27-27: Dependency Update for @polkadot/util-crypto
The bump of@polkadot/util-cryptoto^13.3.1in the dependencies section is in line with recent updates across the repo. Ensure that any usage of this package in your utility functions is compatible with the changes in the new version.
33-48: DevDependencies Version Standardization
The versions for@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitestin the devDependencies have been updated to maintain consistency across all packages. This streamlined update should reduce conflicts and improve maintainability.packages/request/package.json (2)
30-30: Dependency Version Update: "uuid"
The dependency"uuid"has been updated to"^11.0.5", which aligns with the version bumps in other packages. This ensures consistency across the repository.
34-49: DevDependencies Version Bumps
The updates for devDependencies (including@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitest) are consistent with the overall maintenance effort across the project. Please ensure your build and test pipelines validate these updates.packages/signers/bitcoin/package.json (1)
35-50: Consistent DevDependencies Upgrades
The devDependencies updates—updating@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitest—are in line with project-wide upgrades. This should help maintain compatibility and alignment across packages.packages/signers/ethereum/package.json (1)
35-50: DevDependencies Update Verification
The updated versions for@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitestin the Ethereum signer package are consistent with the other packages' updates. No issues detected.packages/signers/polkadot/package.json (2)
25-28: Dependencies Update: Commitlint and Polkadot Utilities
The dependency updates—upgrading@commitlint/clito"^19.7.1", and bumping@polkadot/utiland@polkadot/util-cryptoto"^13.3.1"—ensure you are leveraging the latest releases for improved stability and compatibility.
34-49: DevDependencies Upgrade Consistency
DevDependencies in this file have been updated (@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitest), which keeps the development tools in sync across packages. It is advised to verify that the build and test processes pass after these changes.packages/keyring/package.json (2)
32-32: Dependency Update: "@polkadot/util"
The update of@polkadot/utilto"^13.3.1"in the dependencies section is a welcome change that ensures compatibility with the latest improvements offered by the package.
37-52: DevDependencies Version Alignment
The devDependencies—updating@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitest—reflect a consistent upgrade strategy across the repository. Please confirm that these updates do not disrupt existing workflows.packages/extension-bridge/package.json (2)
42-42: Dependency Version Update for "serialize-error".
The dependency has been bumped from a previous version to"12.0.0", which should bring improvements and fixes. Please verify that there are no breaking changes introduced by this upgrade.
47-64: DevDependency Upgrades.
Multiple devDependencies (such as@types/node,bumpp,eslint,prettier,tsup,type-fest,typescript, andtypescript-eslint) have been updated. These updates help maintain consistency across the project’s packages. Ensure that your TypeScript configuration and linting rules work as expected with these new versions.packages/swap/package.json (2)
27-29: Dependency Updates in Swap Package.
The versions for@solana/spl-token,@solana/web3.js,rango-sdk-basic, anduuidhave been updated. These changes align with broader ecosystem upgrades. Please test that the swap functionalities—which rely on these libraries—continue to behave correctly.
42-57: DevDependency Version Bumps in Swap Package.
The devDependencies now use updated versions for packages like@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitest. This helps maintain a consistent development environment across packages. Verify that your build, lint, and test scripts remain fully functional.package.json (1)
35-41: Root DevDependencies Upgrade.
The versions for development tools (@commitlint/cli,@commitlint/config-conventional,@swc/core,concurrently,husky, andnodemon) have been bumped. These updates enhance the development experience and ensure consistency in pre-commit and build hooks. Double-check for any potential integration issues with these new versions.packages/hw-wallets/package.json (2)
25-40: hw-wallets DevDependencies Updates.
The devDependencies (including@types/node,eslint,prettier,tsup,typescript,typescript-eslint, andvitest) have been updated to newer versions. This is in line with the changes in other packages and should help standardize the development workflow. Please ensure that your build and test processes complete without issues.
55-66: hw-wallets Dependencies Bump.
Several wallet-related dependencies such as@ledgerhq/hw-app-btc,@ledgerhq/hw-app-eth,@ledgerhq/live-common,@polkadot/types,@polkadot/util,@trezor/connect,@trezor/connect-webextension,@zondax/ledger-substrate, andbitcoinjs-libhave been updated. Confirm that these changes are compatible with the underlying hardware wallet workflows and that integration tests pass successfully.packages/extension/package.json (3)
26-40: Extension Package: Dependency Enhancements.
This section updates key dependencies including an upgrade of@amplitude/analytics-browser, introduces a new dependency (@ethereumjs/walletat version^2.0.4), and bumps the versions for@kadena/clientand@kadena/pactjs-clito^1.16.0. These changes should improve feature support and align with the overall project upgrade strategy. Please verify that the wallet and blockchain integrations work as intended.
26-89: Broad Dependency Updates.
A significant block of dependencies—including blockchain SDKs, wallet libraries, and UI utilities—has been updated (e.g., for various@polkadot,@solana, and related packages). This reflects a coordinated effort to use more recent library versions. It is important to perform thorough integration testing to ensure that these updates do not disrupt existing functionalities.
90-141: Updated DevDependencies for Enhanced Build and Tooling.
In the devDependencies section, several build tools, TypeScript plugins, and linting utilities (such as updates to@crxjs/vite-plugin, various Rollup plugins,eslint,prettier, andviteamong others) have been upgraded. This should result in an improved development experience. Please run your build and test pipelines to confirm that all tools integrate seamlessly with these updates.
…t into devop/update-zerox-api
gamalielhere
changed the base branch from
devop/upgrade-packages
to
devop/release-2.2.2
Summary by CodeRabbit
Chores
Refactor
Style