Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically disable MenuButton dropdown #2878

Open
edloidas opened this issue Nov 21, 2022 · 0 comments
Open

Automatically disable MenuButton dropdown #2878

edloidas opened this issue Nov 21, 2022 · 0 comments
Labels
Improvement Suggestion for improvement

Comments

@edloidas
Copy link
Member

There is the MenuButton's method updateActionEnabled(). It is private and is called manually.
It will be more sense to listen to action's property change and enable/disable dropdown accordingly.

Make sure the menu dropdown state in apps won't break after this change.
It will make sense to prevent dropdown from being enabled manually and have '.no-animation' CSS class by default.
@edloidas edloidas added the Improvement Suggestion for improvement label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Suggestion for improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edloidas