Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation refactoring #2966

Open
ashklianko opened this issue Jan 11, 2023 · 0 comments
Open

Validation refactoring #2966

ashklianko opened this issue Jan 11, 2023 · 0 comments
Labels
Refactoring Code improvements

Comments

@ashklianko
Copy link
Member

  1. Potential error in Form.ts where single fieldset validation state change by some reason declares that entire form validation state is the same as in the fieldset
fieldset.onValidityChanged((event) => {
     this.notifyValidityChanged(event.isValid());
});
  1. Form, FormView, InputTypeView (potentially more classes) apply different approaches to validation: some return validation result, some don't.
  2. Develop common approach to validation and api for it (we definately missing isValid() method)

To be continued after further code inspection

@ashklianko ashklianko added the Refactoring Code improvements label Jan 11, 2023
@ashklianko ashklianko changed the title Form validation refactoring Validation refactoring Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Code improvements
Projects
None yet
Development

No branches or pull requests

1 participant