Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve recurrent transactions visibility in the transaction-list page #254

Open
4 tasks done
enrique-lozano opened this issue Nov 14, 2024 · 7 comments
Open
4 tasks done
Assignees
Labels
type: enhancement New feature or request

Comments

@enrique-lozano
Copy link
Owner

enrique-lozano commented Nov 14, 2024

Prerequisites

Current Behavior

With the current app version, we can only see the next item that will come from a recurring transaction, without any extra information. Also, there is no easy way to distinguish future transactions or pending transactions from the rest.

Expected Behavior

It is proposed to do something similar to what the excellent 1Money app is doing right now:

Here we have the should consider the following points:

  • We should introduce a banner with the number of pending transactions that we have
  • The page should be initially scrolled to this banner, hiding everything above it
  • In case of recurrent transactions, only the first value of the recurrence should be displayed, as before
  • All the transactions above this new banner should be greyed-out
  • We have to study if past pending transactions should change from what we have now. That is, apply change can only apply to future pending transactions or to all the pending transactions. I think we should start by applying this to only the future transactions

Steps to Reproduce

To generate a good test for this functionality, it would be good to create at least two recurring transactions, with a small periodicity (weekly or daily) or without an end date. With this, we could obtain a few future transactions and try to filter by dates and other parameters

Additional Information

This issue is based on the discussion generated in #243, with @shinebrillant, @vincius0000 and @enrique-lozano as participants. We should also consider the more in-deep analysis made here.

As always, if you want to collaborate on this, PRs are accepted.

@enrique-lozano enrique-lozano added the type: enhancement New feature or request label Nov 14, 2024
@vincius0000
Copy link
Contributor

I'm excited to work on it, not sure when I will start to, perhaps tomorrow. Shall I comment when I start just to be sure two devs don't work on the same?

@enrique-lozano
Copy link
Owner Author

enrique-lozano commented Nov 15, 2024

Yes please, and assign yourself the task if you want too :)

Thanks a lot!!

@vincius0000
Copy link
Contributor

vincius0000 commented Nov 15, 2024

Last time I've checked I did not have permission to assign myself, must be repository permission settings 🤔

@enrique-lozano
Copy link
Owner Author

Done 😊

@enrique-lozano
Copy link
Owner Author

Hi @vincius0000, please contact me at [email protected] if you have any questions or if you want to share your progress

@victor-marino
Copy link

Fully agree with this.

Additionally, I'm thinking perhaps we could offer the option of notifying the user when the deadline of a pending transaction has passed? Otherwise it's easy to forget marking them as paid.

What do you think?

@enrique-lozano
Copy link
Owner Author

Fully agree with this.

Additionally, I'm thinking perhaps we could offer the option of notifying the user when the deadline of a pending transaction has passed? Otherwise it's easy to forget marking them as paid.

What do you think?

Yes, I totally agree. However, we don't have right now any kind of notifications implemented in the app, so it will require a bit of work to introduce them.

That would be part of another task, but for sure a nice addition to the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants