Add the iframe provider to support parent window based wallets #388
Conversation
Adds the iframe provider polyfill to index.html so that wallets like Ethvault.xyz can be used to interact with ENS
* Upgrade ensdomains/ui to fix provider/signer * upgrade npm package
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.0.11 to 4.1.2. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.0.11...v4.1.2) Signed-off-by: dependabot[bot] <[email protected]>
…ebars-4.1.2 Bump handlebars from 4.0.11 to 4.1.2
Reserve link
|
Do you have anyone audited your package? I have a bit of hesitance including a package I don't know if it's secure or not. For other embedded wallets like Portis, Formatic, Universal Login, Authereum etc, we (= dapp developer) switch to their provider/sdk only if end users make conscious choice (eg: by clicking a button with the vendor logo) of using their solution. On the other hand, yours is included by default so I would like to have extra assurance that there is no known security threat . |
|
I can change the PR to be more similar to those other providers-the polyfill is a small wrapper around the iframe provider. It’s only included by default if the window is in an iframe. I haven’t had an audit but I’m aware of at least one issue that is mitigated by limiting the origins that may embed the dapp in an iframe Let me know what steps you would like to see to get this merged |
* Remove contents utils file. Use @ensdomains/ui instead * Update onion placeholder * Add onion link
public/index.html
Outdated
| @@ -64,5 +64,6 @@ | |||
| To begin the development, run `npm start` or `yarn start`. | |||
| To create a production bundle, use `npm run build` or `yarn build`. | |||
| --> | |||
| <script src="https://unpkg.com/@ethvault/[email protected]/dist/index.js" integrity="sha384-qx1eG3ocmrXxXBwEL+qnP7je980Depwy/J7keRHVnqfEFVXHJ0ruzYIsUX767NEH" crossorigin="anonymous"></script> | |||
There was a problem hiding this comment.
Does this have to be included here rather than inside package.json while keeping the integrity hash? We prefer to manage all third party packages in one place.
Adds the iframe provider polyfill to index.html so that wallets like Ethvault.xyz can be used to interact with ENS
|
I did a rebase on the patch branch that github created, which for some reason added all the commits to this PR, so I opened a new one |
Adds the iframe provider polyfill to index.html so that wallets like Ethvault.xyz can be used to interact with ENS