Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chainId instead of networkName in the api urls #76

Open
PeterTheOne opened this issue Feb 18, 2022 · 0 comments
Open

Use chainId instead of networkName in the api urls #76

PeterTheOne opened this issue Feb 18, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@PeterTheOne
Copy link

Please change https://metadata.ens.domains/{networkName}/{contractAddress(0x[a-fA-F0-9]{40})}/{tokenId} into https://metadata.ens.domains/{chainId}/{contractAddress(0x[a-fA-F0-9]{40})}/{tokenId}. ChainIds are universal and stable, networkName are arbitrary. Sometimes ethereum is named mainnet or eth, sometimes network names change like xDai Chain into Gnosis Chain. So please use chainIds, see https://chainlist.org/ for a list of them.

Alternatively you could replace the networksName and contractAddress with a CAPI-10 address, that contains the chainId and the address in one string.

@mdtanrikulu mdtanrikulu added the enhancement New feature or request label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants