Command Palette

[somebody1234]

Pull Request Description

• Close Command Palette #13675 (Add Command Palette)
  • Ctrl+K (non-macOS)/Cmd+K (macOS) to open, Escape to close
  • Supports icons
  • Fully reactive (reloads list of entries when changing between Local and Cloud backends, for example)
  • Uses fuzzysort library to search, and highlight matches
  • Automatically generated from useMenuEntries used for menus on the Dashboard; and registerHandlers used for registering key bindings on the Project View
    • (Edit: registerHandlers are no longer being used to generate Command Palette entries for now because they should be more finely scoped/thought should be taken to make it more intuitive)

Important Notes

Note

Not requested by anyone, just opening for feedback

Screenshots

Search:

With project selected:

Actions on Local backend:

Actions on Cloud backend:

Actions in Editor (two visualizations open):

I guess something needs to be done about deduplication, not sure what though

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  TypeScript,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• Unit tests have been written where possible.
• If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
  or the Snowflake database integration, a run of the Extra Tests has been scheduled.
  • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

[vitvakatu]

My feedback:

I like the idea for the dashboard! It would also be nice to show the shortcuts there as well, as an additional discoverability tool.

For the graph editor, though, the items on the screenshot seem confusing and not useful. It is questionable whether we need all actions from the dashboard available inside graph editor (perhaps some), but also actions should be related to selected components — I don’t want to hide some arbitrary visualization, I want to hide the one that is currently selected!.

With better implementation, it can be helpful on the graph editor side also.

[somebody1234]

It is questionable whether we need all actions from the dashboard available inside graph editor

yeah. not sure what's a good solution here though, how can we detect whether a graph editor tab is currently open?

[vitvakatu]

yeah. not sure what's a good solution here though, how can we detect whether a graph editor tab is currently open?

useContainerData context store has this info, I believe.

[vitvakatu]

It is a user-facing feature, so why no changelog entry?

[vitvakatu]

Do we really need a separate close action? For example, component browser does not have it, but global Esc key works.

[PabloBuchu]

Looks nice!

1. Would be nice if I could navigate with arrows.
2. Looks like it works only once? Opened enso -> cmd + k -> settings -> cmd+k -> nothing. Reload helps
3. Can we group the entries somehow? Like you have in macos spotlight

4. BIlling and Plans settings. I guess we should put a button there Go to Stripe so this action makes sense
5. Some results are doubled

[PabloBuchu]

1. The action of creating a folder, data-link or a secret and being outside of the main dashboard doesn’t redirect you to the created feature. When you go to seetings you can still Create new project but it should redirect back to dashboard