Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null handler #574

Open
mdickinson opened this issue Jun 4, 2024 · 0 comments
Open

Remove null handler #574

mdickinson opened this issue Jun 4, 2024 · 0 comments
Milestone

Comments

@mdickinson
Copy link
Member

Envisage currently adds a logging NullHandler to the "envisage" logger. That has the (deliberate, intended) effect of suppressing log messages from Envisage at WARNING and ERROR level if no handlers have been configured for the root logger.

I suspect that that isn't really what we want, and risks hiding useful information: if something inside Envisage is logging at WARNING or ERROR level, that likely indicates that there's an action to be taken by the user of Envisage.

I'd suggest:

  • reviewing Envisage's uses of logger.warning and logger.error to see if any of those warnings and errors should be downgraded to logger.info or lower, and whether the remaining warnings and errors are reasonably actionable by Envisage users
  • removing the NullHandler
@mdickinson mdickinson added this to the Release 8.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant