You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Envisage currently adds a logging NullHandler to the "envisage" logger. That has the (deliberate, intended) effect of suppressing log messages from Envisage at WARNING and ERROR level if no handlers have been configured for the root logger.
I suspect that that isn't really what we want, and risks hiding useful information: if something inside Envisage is logging at WARNING or ERROR level, that likely indicates that there's an action to be taken by the user of Envisage.
I'd suggest:
reviewing Envisage's uses of logger.warning and logger.error to see if any of those warnings and errors should be downgraded to logger.info or lower, and whether the remaining warnings and errors are reasonably actionable by Envisage users
removing the NullHandler
The text was updated successfully, but these errors were encountered:
Envisage currently adds a logging
NullHandler
to the"envisage"
logger. That has the (deliberate, intended) effect of suppressing log messages from Envisage at WARNING and ERROR level if no handlers have been configured for the root logger.I suspect that that isn't really what we want, and risks hiding useful information: if something inside Envisage is logging at WARNING or ERROR level, that likely indicates that there's an action to be taken by the user of Envisage.
I'd suggest:
logger.warning
andlogger.error
to see if any of those warnings and errors should be downgraded tologger.info
or lower, and whether the remaining warnings and errors are reasonably actionable by Envisage usersNullHandler
The text was updated successfully, but these errors were encountered: