Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetuptoolsEggMetadata.from_egg does not respect the platform abi of the eggs #419

Open
itziakos opened this issue Jun 28, 2021 · 0 comments
Labels

Comments

@itziakos
Copy link
Member

itziakos commented Jun 28, 2021

The from_egg constructor will ignore the platform abi info commonly encoded in the name of setuptools eggs in favor of the EPDPlatform instance passed into the constructor. So it is possible for example to create SetuptoolEggMetadata instances of a linux egg that claims the egg is a windows 32 bit binary egg.

Ideally okonomiyaki should be able to tell if the setuptools egg platform is compatible with the passed EPDPlatform instance, but at least I would expect that if the passed EPDPlatform instance declares a different platform abi than the discovered (if available) encoded in the name, then a warning is raised to notify the users of possible issues.

@itziakos itziakos added the bug label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant