Merge branch 'test' into fix/pat-synapse-repr-leak-850

Author: plind-junior

gittensor/classes.py

@@ -83,6 +83,7 @@ def is_test_file(self) -> bool:
             r'(^|/)androidtest[a-z]*/',
             r'(^|/)integrationtest/',
             r'(^|/)spec/',
+            r'\.tests?/',  # .NET MyProject.Tests/FooTests.cs
         ]
         if any(re.search(pattern, filename_lower) for pattern in test_dir_patterns):
             return True
@@ -98,6 +99,7 @@ def is_test_file(self) -> bool:
             r'\.spec\.[^.]+$',
             r'^test\.[^.]+$',
             r'^tests\.[^.]+$',
+            r'^conftest\.py$',
         ]
 
         return any(re.search(pattern, basename) for pattern in test_patterns)

gittensor/cli/issue_commands/helpers.py

@@ -784,8 +784,7 @@ def _read_issues_from_child_storage(substrate, contract_addr: str, verbose: bool
         console.print(f'[dim]Debug: next_issue_id from contract = {next_issue_id}[/dim]')
 
     # Sanity check: next_issue_id should be reasonable (< 1 million for any real deployment)
-    MAX_REASONABLE_ISSUE_ID = 1_000_000
-    if next_issue_id > MAX_REASONABLE_ISSUE_ID:
+    if next_issue_id > MAX_ISSUE_ID:
         console.print(f'[yellow]Warning: next_issue_id ({next_issue_id}) is unreasonably large.[/yellow]')
         console.print('[yellow]This may indicate a storage format mismatch. Check contract version.[/yellow]')
         return []

gittensor/cli/issue_commands/view.py

@@ -29,6 +29,7 @@
     handle_exception,
     print_network_header,
     read_issues_from_contract,
+    validate_issue_id,
     with_cli_behavior_options,
     with_network_contract_options,
 )
@@ -42,13 +43,22 @@
     type=int,
     help='View a specific issue by ID',
 )
+@click.option(
+    '--repo',
+    'repo_filter',
+    default=None,
+    type=str,
+    help='Filter issues to a specific repository (owner/name).',
+)
 @with_cli_behavior_options(
     include_verbose=True,
     include_json=True,
     verbose_help='Show debug output for contract reads',
 )
 @with_network_contract_options('Contract address (uses default if empty)')
-def issues_list(issue_id: int, network: str, rpc_url: str, contract: str, verbose: bool, as_json: bool):
+def issues_list(
+    issue_id: int, repo_filter: str, network: str, rpc_url: str, contract: str, verbose: bool, as_json: bool
+):
     """List issues or view a specific issue.
 
     [dim]Examples:
@@ -58,6 +68,12 @@ def issues_list(issue_id: int, network: str, rpc_url: str, contract: str, verbos
         $ gitt i list --json
     [/dim]
     """
+    if issue_id is not None:
+        try:
+            validate_issue_id(issue_id, 'id')
+        except click.BadParameter as e:
+            handle_exception(as_json, str(e), 'bad_parameter')
+
     contract_addr, ws_endpoint, network_name = _resolve_contract_and_network(
         contract,
         network,
@@ -76,6 +92,11 @@ def issues_list(issue_id: int, network: str, rpc_url: str, contract: str, verbos
         for issue in issues:
             issue['bounty_alpha'] = format_alpha(issue.get('bounty_amount', 0), 4)
             issue['target_alpha'] = format_alpha(issue.get('target_bounty', 0), 4)
+
+        # Apply --repo filter before rendering (--id takes precedence)
+        if repo_filter and issue_id is None:
+            issues = [i for i in issues if i.get('repository_full_name', '').lower() == repo_filter.lower()]
+
         if issue_id is not None:
             issue = next((i for i in issues if i['id'] == issue_id), None)
             if issue is None:
@@ -110,6 +131,10 @@ def issues_list(issue_id: int, network: str, rpc_url: str, contract: str, verbos
             handle_exception(as_json, f'Issue {issue_id} not found on-chain.', 'not_found')
         return
 
+    # Apply --repo filter before table render (--id takes precedence)
+    if repo_filter and issue_id is None:
+        issues = [i for i in issues if i.get('repository_full_name', '').lower() == repo_filter.lower()]
+
     # Table view of all issues
     console.print('[bold cyan]Available Issues[/bold cyan]\n')
 

gittensor/cli/main.py

@@ -16,8 +16,9 @@
 import os
 import sys
 
-# Stub heavy imports during shell completion so tab-completion stays fast.
-if os.environ.get('_GITT_COMPLETE'):
+# Stub heavy imports during shell completion and --help so tab-completion stays
+# fast and bittensor's argparse doesn't hijack click's help output.
+if os.environ.get('_GITT_COMPLETE') or any(arg in ('-h', '--help') for arg in sys.argv[1:]):
     import types as _types
 
     class _Stub(_types.ModuleType):
@@ -27,7 +28,7 @@ def __getattr__(self, _name):
         def __call__(self, *_a, **_kw):
             return self
 
-    _stub = _Stub('_gitt_completion_stub')
+    _stub = _Stub('_gitt_cli_stub')
     for _pkg in ('bittensor', 'requests'):
         sys.modules[_pkg] = _stub
 

gittensor/utils/github_api_tools.py

@@ -319,7 +319,7 @@ def get_merge_base_sha(repository: str, base_sha: str, head_sha: str, token: str
     return None
 
 
-def get_pull_request_file_changes(repository: str, pr_number: int, token: str) -> Optional[List[FileChange]]:
+def get_pull_request_file_changes(repository: str, pr_number: int, token: str) -> List[FileChange]:
     """
     Get the diff for a specific PR by repository name and PR number.
 
@@ -333,7 +333,7 @@ def get_pull_request_file_changes(repository: str, pr_number: int, token: str) -
         pr_number (int): PR number
         token (str): Github pat
     Returns:
-        List[FileChanges]: List object with file changes or None if error
+        List[FileChanges]: List object with file changes or empty list if error
     """
     max_attempts = 3
     per_page = 100

gittensor/validator/issue_competitions/forward.py

@@ -136,7 +136,7 @@ async def issue_competitions(
                         bt.logging.info(f'Voted cancel (solver {solver_github_id} not eligible): {issue_label}')
                     continue
 
-                miner_coldkey = get_miner_coldkey(miner_hotkey, self.subtensor, self.config.netuid)  # type: ignore[attr-defined]
+                miner_coldkey = get_miner_coldkey(miner_hotkey, self.subtensor)
                 if not miner_coldkey:
                     bt.logging.warning(
                         f'Could not get coldkey for hotkey {miner_hotkey} (solver {solver_github_id}): {issue_label}'

gittensor/validator/utils/issue_competitions.py

@@ -8,14 +8,13 @@
 import bittensor as bt
 
 
-def get_miner_coldkey(hotkey: str, subtensor: bt.Subtensor, netuid: int) -> Optional[str]:
+def get_miner_coldkey(hotkey: str, subtensor: bt.Subtensor) -> Optional[str]:
     """
     Get the coldkey for a miner's hotkey.
 
     Args:
         hotkey: Miner's hotkey address
         subtensor: Bittensor subtensor instance
-        netuid: Network UID
 
     Returns:
         Coldkey address or None

tests/cli/test_issues_list_json.py

@@ -6,6 +6,8 @@
 import json
 from unittest.mock import patch
 
+import pytest
+
 FAKE_ISSUES = [
     {
         'id': 1,
@@ -51,3 +53,28 @@ def test_issues_list_human_missing_issue_exits_non_zero(cli_root, runner):
     assert result.exit_code != 0
     assert '999' in result.output
     assert 'not found' in result.output.lower()
+
+
+@pytest.mark.parametrize('bad_id', ['0', '-1', '1000000', '99999999999999'])
+def test_issues_list_rejects_invalid_id_human(cli_root, runner, bad_id):
+    """Out-of-range --id must be rejected at parse time without any contract read."""
+    with patch('gittensor.cli.issue_commands.view.read_issues_from_contract') as mock_read:
+        result = runner.invoke(cli_root, ['issues', 'list', '--id', bad_id], catch_exceptions=False)
+
+    assert result.exit_code != 0
+    assert 'between 1 and 999999' in result.output
+    mock_read.assert_not_called()
+
+
+@pytest.mark.parametrize('bad_id', ['0', '-1', '1000000'])
+def test_issues_list_rejects_invalid_id_json(cli_root, runner, bad_id):
+    """JSON mode must emit a structured bad_parameter error consistent with `submissions --id`."""
+    with patch('gittensor.cli.issue_commands.view.read_issues_from_contract') as mock_read:
+        result = runner.invoke(cli_root, ['issues', 'list', '--json', '--id', bad_id], catch_exceptions=False)
+
+    assert result.exit_code != 0
+    payload = json.loads(result.output)
+    assert payload['success'] is False
+    assert payload['error']['type'] == 'bad_parameter'
+    assert 'between 1 and 999999' in payload['error']['message']
+    mock_read.assert_not_called()

tests/test_classes.py

@@ -72,6 +72,30 @@ def test_is_test_file_preserves_existing_test_conventions():
     assert _file_change('src/foo/bar.py').is_test_file() is False
 
 
+@pytest.mark.parametrize(
+    'filename',
+    [
+        'src/MyProject.Tests/AccountServiceTests.cs',
+        'src/MyProject.Tests/AccountServiceTest.cs',
+    ],
+)
+def test_is_test_file_detects_dotnet_dotted_tests_directory(filename):
+    assert _file_change(filename).is_test_file() is True
+
+
+@pytest.mark.parametrize(
+    'filename',
+    [
+        'conftest.py',
+        'tests/conftest.py',
+        'project/conftest.py',
+        'project/sub/package/conftest.py',
+    ],
+)
+def test_is_test_file_detects_conftest_at_any_depth(filename):
+    assert _file_change(filename).is_test_file() is True
+
+
 def test_pull_request_handles_deleted_label_event():
     pr_data = {
         'number': 42,