cleanup

Signed-off-by: Takeshi Yoneda <[email protected]>

Author: mathetake

README.md

@@ -15,7 +15,7 @@ Future examples will be added in other languages once the support is available.
 This repository serves as a reference for developers who want to create their own dynamic modules for Envoy including
 how to setup the project, how to build it, and how to test it, etc.
 
-## Dvelopment
+## Development
 
 ### Rust Dynamic Module
 
@@ -45,7 +45,7 @@ The example Envoy configuration yaml is in `integration/envoy.yaml` which is als
 to run the integration tests. Assuming you built the Docker image with the tag `envoy-with-dynamic-modules:latest`, you can run Envoy with the following command:
 
 ```
-docker run -p 1062:1062  -v $(pwd):/examples -w /examples/integration envoy-with-dynamic-modules:latest --config-path ./envoy.yaml
+docker run --network host -v $(pwd):/examples -w /examples/integration envoy-with-dynamic-modules:latest --config-path ./envoy.yaml
 ```
 
 Then execute, for example, the following command to test the `echo` filter:
@@ -63,7 +63,7 @@ To update the Envoy version used in this repository, execute the following comma
 
 ```
 CURRENT_VERSION="$(cat ENVOY_VERSION)"
-NEW_VERSION=80c1ac2143a7a73932c9dff814d38fd6867fe691 # Whatever the head commit in envoyproxy/envoy repo.
+NEW_VERSION=80c1ac2143a7a73932c9dff814d38fd6867fe691 # Whatever the commit in envoyproxy/envoy repo.
 grep -rlF "${CURRENT_VERSION}" . | xargs sed -i "s/${CURRENT_VERSION}/${NEW_VERSION}/g"
 ```
 

integration/main_test.go

@@ -27,7 +27,7 @@ func TestIntegration(t *testing.T) {
 	cmd := exec.Command(
 		"docker",
 		"run",
-		"-p", "1062:1062",
+		"--network", "host",
 		"-v", cwd+":/integration",
 		"-w", "/integration",
 		envoyImage,
@@ -42,9 +42,9 @@ func TestIntegration(t *testing.T) {
 		require.NoError(t, cmd.Process.Kill())
 	})
 
-	// Let's wait at least 10 seconds for Envoy to start since it might take a while
+	// Let's wait at least 5 seconds for Envoy to start since it might take a while
 	// to pull the image.
-	time.Sleep(10 * time.Second)
+	time.Sleep(5 * time.Second)
 
 	t.Run("health checking", func(t *testing.T) {
 		require.Eventually(t, func() bool {

rust/src/lib.rs

@@ -17,7 +17,7 @@ fn init() -> bool {
 /// This is the entrypoint every time a new HTTP filter is created via the DynamicModuleFilter config.
 ///
 /// Each argument matches the corresponding argument in the Envoy config here:
-/// https://storage.googleapis.com/envoy-pr/be95c85/docs/api-v3/extensions/filters/http/dynamic_modules/v3/dynamic_modules.proto.html#envoy-v3-api-msg-extensions-filters-http-dynamic-modules-v3-dynamicmodulefilter
+/// https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/dynamic_modules/v3/dynamic_modules.proto#envoy-v3-api-msg-extensions-dynamic-modules-v3-dynamicmoduleconfig
 fn new_http_filter_config_fn<EC: EnvoyHttpFilterConfig, EHF: EnvoyHttpFilter>(
     _envoy_filter_config: &mut EC,
     filter_name: &str,