Skip to content

Commit d8b45a1

Browse files
committed
opentelemetrytracer: log the number of exported spans
1 parent f122866 commit d8b45a1

File tree

3 files changed

+21
-0
lines changed

3 files changed

+21
-0
lines changed

source/extensions/tracers/opentelemetry/grpc_trace_exporter.cc

+1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ void OpenTelemetryGrpcTraceExporter::onFailure(Grpc::Status::GrpcStatus status,
4242
bool OpenTelemetryGrpcTraceExporter::log(const ExportTraceServiceRequest& request) {
4343
client_->send(service_method_, request, *this, Tracing::NullSpan::instance(),
4444
Http::AsyncClient::RequestOptions());
45+
OpenTelemetryTraceExporter::logExportedSpans(request);
4546
return true;
4647
}
4748

source/extensions/tracers/opentelemetry/http_trace_exporter.cc

+2
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ bool OpenTelemetryHttpTraceExporter::log(const ExportTraceServiceRequest& reques
7070
Http::AsyncClient::Request* in_flight_request =
7171
thread_local_cluster->httpAsyncClient().send(std::move(message), *this, options);
7272

73+
OpenTelemetryTraceExporter::logExportedSpans(request);
74+
7375
if (in_flight_request == nullptr) {
7476
return false;
7577
}

source/extensions/tracers/opentelemetry/trace_exporter.h

+18
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,24 @@ class OpenTelemetryTraceExporter : public Logger::Loggable<Logger::Id::tracing>
2929
* @return false When sending the request failed.
3030
*/
3131
virtual bool log(const ExportTraceServiceRequest& request) = 0;
32+
33+
/**
34+
* @brief Logs as debug the number of exported spans.
35+
*
36+
* @param request The protobuf-encoded OTLP trace request.
37+
*/
38+
void logExportedSpans(const ExportTraceServiceRequest& request) {
39+
if (!ENVOY_LOG_COMP_LEVEL_FINE_GRAIN_IF(ENVOY_LOGGER(), debug)) {
40+
return;
41+
}
42+
43+
if (request.resource_spans(0).has_resource()) {
44+
if (request.resource_spans(0).scope_spans(0).has_scope()) {
45+
ENVOY_LOG(debug, "Number of exported spans: {}",
46+
request.resource_spans(0).scope_spans(0).spans_size());
47+
}
48+
}
49+
}
3250
};
3351

3452
using OpenTelemetryTraceExporterPtr = std::unique_ptr<OpenTelemetryTraceExporter>;

0 commit comments

Comments
 (0)