xds: refactor the ads_mux from the cluster-manager to the xDS-manager#39219
Merged
adisuissa merged 4 commits intoenvoyproxy:mainfrom Apr 30, 2025
Merged
xds: refactor the ads_mux from the cluster-manager to the xDS-manager#39219adisuissa merged 4 commits intoenvoyproxy:mainfrom
adisuissa merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Contributor
Author
|
/retest |
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Contributor
Author
|
/retest |
mattklein123
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: xds: refactor the ads_mux from the cluster-manager to the xDS-manager
Additional Description:
A big refactor that moves the ads_mux from the Cluster-Manager to the xDS-Manager.
As part of that the functionality that allows replacing the ads_mux (and the associated tests) have also been moved to the correct component.
Unfortunately this ended up being a bigger refactor then initially planned as the ads_mux wasn't abstracted in the cluster-manager.
Risk Level: low
Testing: Updated tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A