move EnvoyPorxy validation out of Provider

Signed-off-by: zirain <[email protected]>

Author: zirain

api/v1alpha1/validation/envoyproxy_validate.go

@@ -238,10 +238,7 @@ func validateProxyAccessLog(accessLog *egv1a1.ProxyAccessLog) []error {
 					errs = append(errs, err)
 				}
 			case egv1a1.ProxyAccessLogFormatTypeJSON:
-				if setting.Format.JSON == nil {
-					err := fmt.Errorf("unable to configure access log when using JSON format but \"json\" field being empty")
-					errs = append(errs, err)
-				}
+				// TODO: add JSON format validation if needed
 			}
 		}
 

internal/cmd/egctl/testdata/translate/out/invalid-envoyproxy.all.yaml

@@ -43,365 +43,3 @@ gatewayClass:
       reason: InvalidParameters
       status: "False"
       type: Accepted
-gateways:
-- apiVersion: gateway.networking.k8s.io/v1
-  kind: Gateway
-  metadata:
-    creationTimestamp: null
-    name: eg
-    namespace: default
-  spec:
-    gatewayClassName: eg
-    listeners:
-    - allowedRoutes:
-        namespaces:
-          from: Same
-      name: tcp
-      port: 1234
-      protocol: TCP
-    - allowedRoutes:
-        namespaces:
-          from: Same
-      name: udp
-      port: 1234
-      protocol: UDP
-    - allowedRoutes:
-        namespaces:
-          from: Same
-      hostname: foo.com
-      name: tls-passthrough
-      port: 8443
-      protocol: TLS
-      tls:
-        mode: Passthrough
-    - allowedRoutes:
-        kinds:
-        - group: gateway.networking.k8s.io
-          kind: HTTPRoute
-        namespaces:
-          from: Same
-      name: http
-      port: 80
-      protocol: HTTP
-    - allowedRoutes:
-        kinds:
-        - group: gateway.networking.k8s.io
-          kind: GRPCRoute
-        namespaces:
-          from: Same
-      name: grpc
-      port: 8080
-      protocol: HTTP
-  status:
-    listeners:
-    - attachedRoutes: 1
-      conditions:
-      - lastTransitionTime: null
-        message: Sending translated listener configuration to the data plane
-        reason: Programmed
-        status: "True"
-        type: Programmed
-      - lastTransitionTime: null
-        message: Listener has been successfully translated
-        reason: Accepted
-        status: "True"
-        type: Accepted
-      - lastTransitionTime: null
-        message: Listener references have been resolved
-        reason: ResolvedRefs
-        status: "True"
-        type: ResolvedRefs
-      name: tcp
-      supportedKinds:
-      - group: gateway.networking.k8s.io
-        kind: TCPRoute
-    - attachedRoutes: 1
-      conditions:
-      - lastTransitionTime: null
-        message: Sending translated listener configuration to the data plane
-        reason: Programmed
-        status: "True"
-        type: Programmed
-      - lastTransitionTime: null
-        message: Listener has been successfully translated
-        reason: Accepted
-        status: "True"
-        type: Accepted
-      - lastTransitionTime: null
-        message: Listener references have been resolved
-        reason: ResolvedRefs
-        status: "True"
-        type: ResolvedRefs
-      name: udp
-      supportedKinds:
-      - group: gateway.networking.k8s.io
-        kind: UDPRoute
-    - attachedRoutes: 1
-      conditions:
-      - lastTransitionTime: null
-        message: Sending translated listener configuration to the data plane
-        reason: Programmed
-        status: "True"
-        type: Programmed
-      - lastTransitionTime: null
-        message: Listener has been successfully translated
-        reason: Accepted
-        status: "True"
-        type: Accepted
-      - lastTransitionTime: null
-        message: Listener references have been resolved
-        reason: ResolvedRefs
-        status: "True"
-        type: ResolvedRefs
-      name: tls-passthrough
-      supportedKinds:
-      - group: gateway.networking.k8s.io
-        kind: TLSRoute
-    - attachedRoutes: 1
-      conditions:
-      - lastTransitionTime: null
-        message: Sending translated listener configuration to the data plane
-        reason: Programmed
-        status: "True"
-        type: Programmed
-      - lastTransitionTime: null
-        message: Listener has been successfully translated
-        reason: Accepted
-        status: "True"
-        type: Accepted
-      - lastTransitionTime: null
-        message: Listener references have been resolved
-        reason: ResolvedRefs
-        status: "True"
-        type: ResolvedRefs
-      name: http
-      supportedKinds:
-      - group: gateway.networking.k8s.io
-        kind: HTTPRoute
-    - attachedRoutes: 1
-      conditions:
-      - lastTransitionTime: null
-        message: Sending translated listener configuration to the data plane
-        reason: Programmed
-        status: "True"
-        type: Programmed
-      - lastTransitionTime: null
-        message: Listener has been successfully translated
-        reason: Accepted
-        status: "True"
-        type: Accepted
-      - lastTransitionTime: null
-        message: Listener references have been resolved
-        reason: ResolvedRefs
-        status: "True"
-        type: ResolvedRefs
-      name: grpc
-      supportedKinds:
-      - group: gateway.networking.k8s.io
-        kind: GRPCRoute
-grpcRoutes:
-- apiVersion: gateway.networking.k8s.io/v1
-  kind: GRPCRoute
-  metadata:
-    creationTimestamp: null
-    name: backend
-    namespace: default
-  spec:
-    hostnames:
-    - www.grpc-example.com
-    parentRefs:
-    - group: gateway.networking.k8s.io
-      kind: Gateway
-      name: eg
-      sectionName: grpc
-    rules:
-    - backendRefs:
-      - group: ""
-        kind: Service
-        name: backend
-        port: 9000
-        weight: 1
-      matches:
-      - method:
-          method: DoThing
-          service: com.example.Things
-          type: Exact
-  status:
-    parents:
-    - conditions:
-      - lastTransitionTime: null
-        message: Route is accepted
-        reason: Accepted
-        status: "True"
-        type: Accepted
-      - lastTransitionTime: null
-        message: Resolved all the Object references for the Route
-        reason: ResolvedRefs
-        status: "True"
-        type: ResolvedRefs
-      controllerName: gateway.envoyproxy.io/gatewayclass-controller
-      parentRef:
-        group: gateway.networking.k8s.io
-        kind: Gateway
-        name: eg
-        sectionName: grpc
-httpRoutes:
-- apiVersion: gateway.networking.k8s.io/v1
-  kind: HTTPRoute
-  metadata:
-    creationTimestamp: null
-    name: backend
-    namespace: default
-  spec:
-    hostnames:
-    - www.example.com
-    parentRefs:
-    - group: gateway.networking.k8s.io
-      kind: Gateway
-      name: eg
-    rules:
-    - backendRefs:
-      - group: ""
-        kind: Service
-        name: backend
-        port: 3000
-        weight: 1
-      matches:
-      - path:
-          type: PathPrefix
-          value: /
-  status:
-    parents:
-    - conditions:
-      - lastTransitionTime: null
-        message: Route is accepted
-        reason: Accepted
-        status: "True"
-        type: Accepted
-      - lastTransitionTime: null
-        message: Resolved all the Object references for the Route
-        reason: ResolvedRefs
-        status: "True"
-        type: ResolvedRefs
-      controllerName: gateway.envoyproxy.io/gatewayclass-controller
-      parentRef:
-        group: gateway.networking.k8s.io
-        kind: Gateway
-        name: eg
-tcpRoutes:
-- apiVersion: gateway.networking.k8s.io/v1alpha2
-  kind: TCPRoute
-  metadata:
-    creationTimestamp: null
-    name: backend
-    namespace: default
-  spec:
-    parentRefs:
-    - group: gateway.networking.k8s.io
-      kind: Gateway
-      name: eg
-      sectionName: tcp
-    rules:
-    - backendRefs:
-      - group: ""
-        kind: Service
-        name: backend
-        port: 3000
-        weight: 1
-  status:
-    parents:
-    - conditions:
-      - lastTransitionTime: null
-        message: Route is accepted
-        reason: Accepted
-        status: "True"
-        type: Accepted
-      - lastTransitionTime: null
-        message: Resolved all the Object references for the Route
-        reason: ResolvedRefs
-        status: "True"
-        type: ResolvedRefs
-      controllerName: gateway.envoyproxy.io/gatewayclass-controller
-      parentRef:
-        group: gateway.networking.k8s.io
-        kind: Gateway
-        name: eg
-        sectionName: tcp
-tlsRoutes:
-- apiVersion: gateway.networking.k8s.io/v1alpha2
-  kind: TLSRoute
-  metadata:
-    creationTimestamp: null
-    name: backend
-    namespace: default
-  spec:
-    parentRefs:
-    - group: gateway.networking.k8s.io
-      kind: Gateway
-      name: eg
-      sectionName: tls-passthrough
-    rules:
-    - backendRefs:
-      - group: ""
-        kind: Service
-        name: backend
-        port: 3000
-        weight: 1
-  status:
-    parents:
-    - conditions:
-      - lastTransitionTime: null
-        message: Route is accepted
-        reason: Accepted
-        status: "True"
-        type: Accepted
-      - lastTransitionTime: null
-        message: Resolved all the Object references for the Route
-        reason: ResolvedRefs
-        status: "True"
-        type: ResolvedRefs
-      controllerName: gateway.envoyproxy.io/gatewayclass-controller
-      parentRef:
-        group: gateway.networking.k8s.io
-        kind: Gateway
-        name: eg
-        sectionName: tls-passthrough
-udpRoutes:
-- apiVersion: gateway.networking.k8s.io/v1alpha2
-  kind: UDPRoute
-  metadata:
-    creationTimestamp: null
-    name: backend
-    namespace: default
-  spec:
-    parentRefs:
-    - group: gateway.networking.k8s.io
-      kind: Gateway
-      name: eg
-      sectionName: udp
-    rules:
-    - backendRefs:
-      - group: ""
-        kind: Service
-        name: backend
-        port: 3000
-        weight: 1
-  status:
-    parents:
-    - conditions:
-      - lastTransitionTime: null
-        message: Route is accepted
-        reason: Accepted
-        status: "True"
-        type: Accepted
-      - lastTransitionTime: null
-        message: Resolved all the Object references for the Route
-        reason: ResolvedRefs
-        status: "True"
-        type: ResolvedRefs
-      controllerName: gateway.envoyproxy.io/gatewayclass-controller
-      parentRef:
-        group: gateway.networking.k8s.io
-        kind: Gateway
-        name: eg
-        sectionName: udp

internal/cmd/egctl/testdata/translate/out/quickstart.all.yaml

@@ -1,3 +1,12 @@
+gatewayClass:
+  apiVersion: gateway.networking.k8s.io/v1
+  kind: GatewayClass
+  metadata:
+    creationTimestamp: null
+    name: eg
+  spec:
+    controllerName: gateway.envoyproxy.io/gatewayclass-controller
+  status: {}
 gateways:
 - apiVersion: gateway.networking.k8s.io/v1
   kind: Gateway