update more

Signed-off-by: zirain <[email protected]>

Author: zirain

internal/gatewayapi/testdata/envoyproxy-accesslog-file-json-no-format.out.yaml

@@ -11,7 +11,13 @@ gatewayClass:
       kind: EnvoyProxy
       name: test
       namespace: envoy-gateway-system
-  status: {}
+  status:
+    conditions:
+    - lastTransitionTime: null
+      message: Valid GatewayClass
+      reason: Accepted
+      status: "True"
+      type: Accepted
 gateways:
 - apiVersion: gateway.networking.k8s.io/v1
   kind: Gateway

internal/gatewayapi/translator.go

@@ -292,8 +292,10 @@ func (t *Translator) GetRelevantGateways(resources *resource.Resources) (
 ) {
 	envoyproxyMap := make(map[types.NamespacedName]*egv1a1.EnvoyProxy, len(resources.EnvoyProxiesForGateways)+1)
 	envoyproxyValidationErrorMap := make(map[types.NamespacedName]error, len(resources.EnvoyProxiesForGateways))
-	// make sure that the EnvoyProxyForGatewayClass is valid
-	// TODO: how to handle EnvoyProxy for GatewayClass not found?
+
+	// if EnvoyProxy not found, provider layer set GC status to not accepted.
+	// if EnvoyProxy found but invalid, set GC status to not accepted,
+	// otherwise set GC status to accepted.
 	if ep := resources.EnvoyProxyForGatewayClass; ep != nil {
 		err := validateEnvoyProxy(ep)
 		if err != nil {
@@ -305,11 +307,14 @@ func (t *Translator) GetRelevantGateways(resources *resource.Resources) (
 				fmt.Sprintf("%s: %v", status.MsgGatewayClassInvalidParams, err))
 			return
 		} else {
-			status.SetGatewayClassAccepted(
-				resources.GatewayClass,
-				true,
-				string(gwapiv1.GatewayClassReasonAccepted),
-				status.MsgValidGatewayClass)
+			// TODO: remove this nil check after we update all the testdata.
+			if resources.GatewayClass != nil {
+				status.SetGatewayClassAccepted(
+					resources.GatewayClass,
+					true,
+					string(gwapiv1.GatewayClassReasonAccepted),
+					status.MsgValidGatewayClass)
+			}
 		}
 
 		key := utils.NamespacedName(ep)