default

Jyoti Mahapatra · Jyoti Mahapatra · commit 4daf7d0a247c · 2020-10-28T11:06:46.000-07:00
Signed-off-by: Jyoti Mahapatra &lt;jmahapatra@lyft.com&gt;
diff --git a/internal/app/upstream/client.go b/internal/app/upstream/client.go
@@ -76,8 +76,7 @@ type CallOptions struct {
 	SendTimeout time.Duration
 
 	// Based on https://github.com/grpc/grpc-go/blob/v1.32.x/keepalive/keepalive.go#L27-L45
-	// The Default timeout is set to infinity
-	// If unset this defaults to infinity, else the string is parsed as a time.Duration
+	// If unset this defaults to 5 minutes
 	UpstreamKeepaliveTimeout string
 }
 

Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,7 @@ type CallOptions struct {`
`76`	`76`	`SendTimeout time.Duration`
`77`	`77`
`78`	`78`	`// Based on https://github.com/grpc/grpc-go/blob/v1.32.x/keepalive/keepalive.go#L27-L45`
`79`		`- // The Default timeout is set to infinity`
`80`		`- // If unset this defaults to infinity, else the string is parsed as a time.Duration`
	`79`	`+ // If unset this defaults to 5 minutes`
`81`	`80`	`UpstreamKeepaliveTimeout string`
`82`	`81`	`}`
`83`	`82`