Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 support #109

Closed
zpao opened this issue Mar 30, 2022 · 7 comments · Fixed by #111
Closed

React 18 support #109

zpao opened this issue Mar 30, 2022 · 7 comments · Fixed by #111

Comments

@zpao
Copy link

zpao commented Mar 30, 2022

In my very very limited use, it doesn't appear to be a problem to just be using React 18 so far, but it would be good to explicitly add 18 to peerDeps if compatible. This would just silence the install time warning.

@NMinhNguyen
Copy link
Collaborator

Sure! Would you like the package version to be bumped to 18.0.0 as well?

@zpao
Copy link
Author

zpao commented Mar 31, 2022

I don't work on react anymore and can't speak for the team, but perhaps @gaearon has an opinion?

@gaearon
Copy link
Collaborator

gaearon commented Mar 31, 2022

We didn’t bump it to 17 so maybe let’s not bump to 18 either? So that it doesn’t seem like it’s part of the release or encouraged for use.

We should probably shim the new Hooks though before the bump (to 16.15 or something). There aren’t that many and implementations should be simple.

@NMinhNguyen
Copy link
Collaborator

We should probably shim the new Hooks though before the bump (to 16.15 or something). There aren’t that many and implementations should be simple.

Could you elaborate on what's required here? But I think you should still have npm and GitHub access so feel free to make the necessary changes yourself

@gaearon
Copy link
Collaborator

gaearon commented Mar 31, 2022

I mean providing some shims for useId etc.

@vharadkou
Copy link

vharadkou commented Apr 6, 2022

Please provide plans to verify merge request above.

it's annoying see every time this picture.

image

@gaearon
Copy link
Collaborator

gaearon commented Apr 6, 2022

Fixed in [email protected].

@gaearon gaearon closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants