From f991ea2964d8be5bb99f815b81e35a3401891c3d Mon Sep 17 00:00:00 2001
From: William Belle <william.belle@gmail.com>
Date: Fri, 1 Dec 2023 16:59:06 +0100
Subject: [PATCH] Clean JS for every Atoms

- Fix eslint warnings and errors
- Fix deprecated jQuery API
---
 assets/components/atoms/drawer/drawer.js   | 6 +++---
 assets/components/atoms/popover/popover.js | 3 +--
 assets/components/atoms/tag/tag-input.js   | 2 +-
 assets/components/atoms/upload/upload.js   | 9 ++++-----
 4 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/assets/components/atoms/drawer/drawer.js b/assets/components/atoms/drawer/drawer.js
index d5909a30b..576aea411 100644
--- a/assets/components/atoms/drawer/drawer.js
+++ b/assets/components/atoms/drawer/drawer.js
@@ -1,10 +1,10 @@
 /* global $ */
 
 const drawer = () => {
-  $('.drawer-toggle').click(function () {
-    const $drawer = $(this).parent('.drawer');
+  $('.drawer-toggle').on('click', (event) => {
+    const $drawer = $(event.currentTarget).parent('.drawer');
     const $drawerLink = $drawer.find('.drawer-link');
-    const $drawerToggle = $(this);
+    const $drawerToggle = $(event.currentTarget);
     const breakpoint = 992;
 
     if ($drawer.hasClass('open')) {
diff --git a/assets/components/atoms/popover/popover.js b/assets/components/atoms/popover/popover.js
index 244f4151f..555af6978 100644
--- a/assets/components/atoms/popover/popover.js
+++ b/assets/components/atoms/popover/popover.js
@@ -1,7 +1,7 @@
 /* globals $ */
 
 export default () => {
-  $(function () {
+  $(() => {
     $('[data-toggle="popover"]').popover({
       placement: 'top',
       html: true,
@@ -10,4 +10,3 @@ export default () => {
     });
   });
 };
-
diff --git a/assets/components/atoms/tag/tag-input.js b/assets/components/atoms/tag/tag-input.js
index b63e6502a..c5645e459 100644
--- a/assets/components/atoms/tag/tag-input.js
+++ b/assets/components/atoms/tag/tag-input.js
@@ -6,7 +6,7 @@ export default () => {
     render: {
       item: (data, escape) => `<div class="tag tag-primary">${escape(data.text)}</div>`,
     },
-    create: input => ({
+    create: (input) => ({
       value: input,
       text: input,
     }),
diff --git a/assets/components/atoms/upload/upload.js b/assets/components/atoms/upload/upload.js
index 0309ddeb9..ed0e45d7f 100644
--- a/assets/components/atoms/upload/upload.js
+++ b/assets/components/atoms/upload/upload.js
@@ -1,20 +1,19 @@
 /* globals $ */
 
 export default () => {
-  $('.upload').find('input[type="file"]').each(function () {
-    const $input = $(this);
+  $('.upload').find('input[type="file"]').each((index, element) => {
+    const $input = $(element);
     const $preview = $input.next().next('.upload-preview');
 
     $input.on('change', () => {
-      const files = $input[0].files;
+      const { files } = $input[0];
       let previewContent = files[0].name;
 
       if (files.length > 1) {
-        previewContent = `<ul>${Array.from(files).map(file => `<li>${file.name}</li>`).join().replace(/,/g, '')}</ul>`;
+        previewContent = `<ul>${Array.from(files).map((file) => `<li>${file.name}</li>`).join().replace(/,/g, '')}</ul>`;
       }
 
       $preview.html(previewContent);
     });
   });
 };
-