Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screen] Conversation List #1499

Open
8 tasks done
nplasterer opened this issue Jan 10, 2025 · 10 comments
Open
8 tasks done

[Screen] Conversation List #1499

nplasterer opened this issue Jan 10, 2025 · 10 comments
Assignees
Labels

Comments

@nplasterer
Copy link
Collaborator

nplasterer commented Jan 10, 2025

When you open the app you see a list of conversations
https://www.figma.com/design/p6mt4tEDltI4mypD3TIgUk/Converse-App?node-id=5026-27441&t=Tso4OHIbfHTlG5bz-0

Screenshot 2025-01-09 at 7 55 20 PM
  • A list of conversations filtered by consent state allowed
  • The last readable message from the conversation (awaiting protocol breakout into new issue)
  • A requests tab item that has the count of conversations filtered by consent state unknown
    • A list of conversations filtered by consent state unknown
  • The ability to pin and unpin a conversation
  • If a pinned conversation has a unread message show the last message as a text bubble
  • Unread state on conversation items and pinned items
  • Ability to swipe right to read a conversation
@nplasterer
Copy link
Collaborator Author

nplasterer commented Jan 10, 2025

@covrter what are the expected swipe actions on a line item? right to mark as read?
What is the interaction that you have to pin a conversation? Long press?

@nplasterer
Copy link
Collaborator Author

Updates
Image

@thierryskoda
Copy link
Collaborator

thierryskoda commented Jan 13, 2025

@nplasterer Right swipe to mark as read, left swipe to delete, long press pops a context menu where you have those options + pin option . Here's the Figma https://www.figma.com/design/PUfpkzt9dFX5GR1U1Fw3mQ/Converse-Global-Styles?node-id=803-14589&t=wmhdp0zDpFq1UVwc-1

@thierryskoda
Copy link
Collaborator

Lots of polished stuff has been done in this PR.

Still want to do more performance tests, iOS/Android tests and many edge cases tests

@covrter
Copy link
Collaborator

covrter commented Jan 16, 2025

Will aggregate feedback up in here

  • Visual QA (marked up screenshots) for the rows/interactions and surrounding UI — Figma link
    • 2/4 — looking awesome, added 1 more spacing note in there (for pinned convos) and tagged you
  • Updated states for Requests row — holler @covrter if this is harder than I think it is
  • default PFPs are looking worse now (want rounded font, poor vertical centering) — should match component in figma pls
  • swipe to read/unread icon changes too fast — it feels weird to see it swap to its new state before the row slides back into place (@thierryskoda mentioned this is an outstanding task)
  • pinned groups don’t display the "many avatars" style pfp (they seem to revert to the "initials" style one)
    • 2/4 — this still seems to be the case

@thierryskoda
Copy link
Collaborator

thierryskoda commented Jan 31, 2025

  • Android: Use Platform specific component for context menu

@thierryskoda
Copy link
Collaborator

thierryskoda commented Feb 4, 2025

  • After creating a new conversation, make sure to start stream on it (messages weren't showing in stream)
  • Android: Context menu on messages weird animation
  • Android: When opening a chat, there's a weird glitch for 0.3 sec. Same every time we leave screen.

@thierryskoda
Copy link
Collaborator

thierryskoda commented Feb 4, 2025

  • The row background color doesn’t change on tap in light mode. Probably just a color token thing.

@covrter
Copy link
Collaborator

covrter commented Feb 5, 2025

Reviewed and updated #1499 (comment) with notes — looking really good, thanks for all of the improvements!

@thierryskoda
Copy link
Collaborator

  • New group conversation showed without title in Andrew's phone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants