Skip to content

Commit 811758e

Browse files
nastassiadanilovaasvae
authored andcommitted
Fix pending issues (#31)
* fix error with reading cssRules property from 'CSSStyleSheet' * add a separate style block to set a frame when spinner was initialized * change some more spinners to a new keyframe binding * chore: remove minified files from repo * chore: add `dist` folder to gitignore * refactor: spinners with dynamic keyframes * Useless code cuts and some commenting * chore: add inputs to demo * chore: add TypeScript declarations close #8 * minor * docs: tree shaking info see #25 * chore: add index.html to .gitignore * build: tweak config according to #16 close #16 * chore: bump version
1 parent b39f465 commit 811758e

16 files changed

+221
-81
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ node_modules/
33
npm-debug.log*
44
yarn-debug.log*
55
yarn-error.log*
6+
dist/
7+
index.html
68

79
# Editor directories and files
810
.idea

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ Vue.js usage example
4343
// import 'epic-spinners/dist/lib/epic-spinners.min.css'
4444
// import {AtomSpinner} from 'epic-spinners/dist/lib/epic-spinners.min.js'
4545
46+
// To get tree shaking from webpack (won't import all spinners when you only need one)
47+
// import AtomSpinner from 'epic-spinners/src/components/lib/AtomSpinner'
48+
4649
import {AtomSpinner} from 'epic-spinners'
4750
export default {
4851
components: {

build/webpack.lib.conf.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ var webpackConfig = merge(baseWebpackConfig, {
2323
devtool: config.lib.productionSourceMap ? '#source-map' : false,
2424
output: {
2525
path: config.lib.assetsRoot,
26-
filename: utils.assetsLibPath('[name].min.js'),
27-
library: '[name]',
26+
filename: utils.assetsLibPath('epic-spinners.min.js'),
27+
library: 'epic-spinners',
2828
libraryTarget: 'umd'
2929
},
3030
plugins: [
@@ -40,10 +40,10 @@ var webpackConfig = merge(baseWebpackConfig, {
4040
}),
4141
// extract css into its own file
4242
new ExtractTextPlugin({
43-
filename: utils.assetsLibPath('[name].min.css')
43+
filename: utils.assetsLibPath('epic-spinners.min.css')
4444
}),
45-
// Compress extracted CSS. We are using this plugin so that possible
46-
// duplicated CSS from different components can be deduped.
45+
// Compress extracted CSS. We are using this plugin so that's possible
46+
// for duplicated CSS from different components to be deduped.
4747
new OptimizeCSSPlugin({
4848
cssProcessorOptions: {
4949
safe: true

dist/lib/epic-spinners.min.css

Lines changed: 0 additions & 1 deletion
This file was deleted.

dist/lib/epic-spinners.min.css.map

Lines changed: 0 additions & 1 deletion
This file was deleted.

dist/lib/epic-spinners.min.js

Lines changed: 0 additions & 2 deletions
This file was deleted.

dist/lib/epic-spinners.min.js.map

Lines changed: 0 additions & 1 deletion
This file was deleted.

index.d.ts

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
declare module 'epic-spinners' {
2+
import { Component } from 'vue'
3+
4+
const HollowDotsSpinner: Component
5+
const PixelSpinner: Component
6+
const FlowerSpinner: Component
7+
const IntersectingCirclesSpinner: Component
8+
const OrbitSpinner: Component
9+
const FingerprintSpinner: Component
10+
const TrinityRingsSpinner: Component
11+
const FulfillingSquareSpinner: Component
12+
const CirclesToRhombusesSpinner: Component
13+
const SemipolarSpinner: Component
14+
const BreedingRhombusSpinner: Component
15+
const SwappingSquaresSpinner: Component
16+
const ScalingSquaresSpinner: Component
17+
const FulfillingBouncingCircleSpinner: Component
18+
const RadarSpinner: Component
19+
const SelfBuildingSquareSpinner: Component
20+
const SpringSpinner: Component
21+
const LoopingRhombusesSpinner: Component
22+
const HalfCircleSpinner: Component
23+
const AtomSpinner: Component
24+
25+
export {
26+
HollowDotsSpinner,
27+
PixelSpinner,
28+
FlowerSpinner,
29+
IntersectingCirclesSpinner,
30+
OrbitSpinner,
31+
FingerprintSpinner,
32+
TrinityRingsSpinner,
33+
FulfillingSquareSpinner,
34+
CirclesToRhombusesSpinner,
35+
SemipolarSpinner,
36+
BreedingRhombusSpinner,
37+
SwappingSquaresSpinner,
38+
ScalingSquaresSpinner,
39+
FulfillingBouncingCircleSpinner,
40+
RadarSpinner,
41+
SelfBuildingSquareSpinner,
42+
SpringSpinner,
43+
LoopingRhombusesSpinner,
44+
HalfCircleSpinner,
45+
AtomSpinner,
46+
}
47+
}

index.html

Lines changed: 0 additions & 1 deletion
This file was deleted.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
{
22
"name": "epic-spinners",
3-
"version": "1.0.4",
3+
"version": "1.1.0",
44
"description": "Easy to use css spinners collection with vue.js integration",
55
"author": "epicmax <[email protected]>",
66
"main": "src/lib.js",
7+
"types": "src/lib.d.ts",
78
"private": false,
89
"license": "MIT",
910
"url": "https://github.com/epicmaxco/epic-spinners",

0 commit comments

Comments
 (0)