Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Supply service chart values when creating a service #338

Closed
Tracked by #252
richard-cox opened this issue Sep 5, 2023 · 3 comments · Fixed by #300
Closed
Tracked by #252

[ui] Supply service chart values when creating a service #338

richard-cox opened this issue Sep 5, 2023 · 3 comments · Fixed by #300
Assignees
@torchiaf
Labels
kind/enhancement New feature or request
Milestone
v1.10.0

Comments

@richard-cox
Copy link
Member

Add / Create side of #252
@richard-cox richard-cox added the kind/enhancement New feature or request label Sep 5, 2023
@richard-cox richard-cox added this to the v1.10.0 milestone Sep 5, 2023
@richard-cox richard-cox mentioned this issue Sep 5, 2023
Closed
@richard-cox richard-cox added this to UI Sep 5, 2023
@richard-cox richard-cox moved this to To Test in UI Sep 5, 2023
@richard-cox richard-cox moved this to In Progress in Epinio planning Sep 5, 2023
@richard-cox richard-cox mentioned this issue Sep 5, 2023
Merged
@richard-cox
Copy link
Member Author

@thehejik given your comment in #252 (comment) (and the work split out to 1.11 #339 and #302) I think we can just close this one?

@richard-cox richard-cox moved this from In Progress to To Review in Epinio planning Sep 5, 2023
@thehejik
Copy link
Contributor

thehejik commented Sep 6, 2023

@richard-cox yes, agree, closing.

@thehejik thehejik closed this as completed Sep 6, 2023
@github-project-automation github-project-automation bot moved this from To Test to Done in UI Sep 6, 2023
@github-project-automation github-project-automation bot moved this from To Review to Done in Epinio planning Sep 6, 2023
@thehejik
Copy link
Contributor

Verified in v1.10.0-rc2 - I could provide custom values defined in my custom service resource over UI, just the edit part in UI is missing (we know about that):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torchiaf torchiaf

Labels
kind/enhancement New feature or request
Projects
Epinio planning
Archived in project
UI
Status: Done
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

[ui] Supply service chart values when creating a service
3 participants
@thehejik @richard-cox @torchiaf