[ui] Confirm UX degrades correctly for apps deployed from private/hosted github/gitlab

[richard-cox]

• Support deploying application from private & enteprise github/gitlab epinio#2236 brings in support for private/hosted github/gitlab
• This comes in for 1.10
• The support for the UI for this is targetted for 1.11 Support application source from private & enterprise github/gitlab #327
• For this release we need to check how the UI performs for Apps that have been deployed with these sources. There should be nothing glaring wrong like errors on page, crashing UI, etc
  • Can the user see the App in the Apps list
  • Can the user see the App Details page
    • The git details should show information provided by the user, but not more (we can't get details regarding repos, branches or commits)
  • Can the user edit the source for the App
    • At this point the user should be able to change FROM these git types but not do things like update the commit

[thehejik]

I can confirm that the limited functionality from description in UI is ok when validating on v1.10.0-rc1.

Verified against private gitlab instance and private repo + private github repo. I always verified that the UI is ok after performing the steps bellow - no inconsistency spotted.

Preparation

• create gitconfigs

# create a gitconfig for gitlab repo (also extra coredns config needed)
$ epinio-1.10 gitconfig create gitlab-private https://gitlab.suse.de \
  --username  thehejik --password glpat-HASH --user-org thehejik \
  --repository sample --git-provider gitlab --cert-file=/home/thehejik/SUSE_Trust_Root.crt.pem

# create a gitconfig for github
$ epinio-1.10 gitconfig create github-private https://github.com \
  --username thehejik --password github_pat_HASH --user-org thehejik \
  --repository sample --git-provider github

Tests

Gitlab (UI app deployment)

• I was going straight to UI app deployment so I selected Source Type: git URL, URL: https://gitlab.suse.de/thehejik/sample and Branch: main
  RESULT: OK the app has been deployed and running
• then I changed my app source code on gitlab via a new commit and pressed Edit Config followed by pressing Update Source
  RESULT: OK the new app from latest commit has been deployed
• then I pressed again Edit Config and entered Branch: d3b13f5 (previous commit) and pressed Update Source
  RESULT: OK the app from previous commit was up and running

Github (CLI app deployment)

• I pushed an app over CLI by epinio-1.10 app push --name github-private-cli-sample --git https://github.com/thehejik/sample/
  RESULT: OK the app deployed and running
• After pressing Edit Config the form was a bit incomplete as expected
  RESULT: OK - the branch value was empty and no commit page appeared (this needs git-proxy for ui)
  
• after changing the Source Type form GitHub to Git URL and entering the branch/commit manually
  RESULT: OK the source was updated successfully, the application has been rebuilt and up
• Following attempt via Edit Config also ok

[enrichman]

@richard-cox we were having a look at this and the checks seems to be fine. Do you think we can close this? 🙂