Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port rpc write api method tests to Sepolia #1931

Open
CHr15F0x opened this issue Apr 5, 2024 · 0 comments
Open

Port rpc write api method tests to Sepolia #1931

CHr15F0x opened this issue Apr 5, 2024 · 0 comments

Comments

@CHr15F0x
Copy link
Member

CHr15F0x commented Apr 5, 2024

By default these tests are ignored, nevertheless they rely on goerli which leads to fails rn:

failures:
    v04::method::add_declare_transaction::tests::duplicate_transaction
    v04::method::add_declare_transaction::tests::duplicate_v3_transaction
    v04::method::add_declare_transaction::tests::insufficient_account_balance
    v04::method::add_declare_transaction::tests::insufficient_max_fee
    v04::method::add_deploy_account_transaction::tests::duplicate_transaction
    v04::method::add_deploy_account_transaction::tests::duplicate_v3_transaction
    v04::method::add_invoke_transaction::tests::duplicate_transaction
    v04::method::add_invoke_transaction::tests::duplicate_v3_transaction
    v06::method::add_declare_transaction::tests::duplicate_transaction
    v06::method::add_declare_transaction::tests::duplicate_v3_transaction
    v06::method::add_declare_transaction::tests::insufficient_account_balance
    v06::method::add_declare_transaction::tests::insufficient_max_fee
    v06::method::add_deploy_account_transaction::tests::duplicate_transaction
    v06::method::add_deploy_account_transaction::tests::duplicate_v3_transaction
    v06::method::add_invoke_transaction::tests::duplicate_transaction
    v06::method::add_invoke_transaction::tests::duplicate_v3_transaction

Imo it does make sense to wait with fixing this issue until at least v0.4 is dropped.

@CHr15F0x CHr15F0x changed the title Port rpc write api methods to Sepolia Port rpc write api method tests to Sepolia Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant