-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Occurences of http #2496
Comments
Task for : |
@meols We have added a check for external link field, if http:// is used, to avoid additional redirect to https:// Also, for existing external urls, we will run a script to replace http:// with https:// |
Thanks @padms - I like this way of solving it, but currently there are some issues
|
@meols This is ready for a second review now.
|
Thanks @padms - is it possible to give some hints to editors on what they need to fix? Not sure what you mean in the first bullet. Can or can't an external url (not equinor.com or satellite sites) have capital letters in the url for external link. |
@padms - also an additional question to confirm - will doing this change mean that we will have to manually rewrite the urls that currently are http or including capital letters to be able to edit and republish a page? E.g. YouTube links I assume and hope that we can just copy/paste. |
@meols We have a script that changes all the urls or( values ) that start with http: and replace it with https:// , no manual editing needed. Fixed the error with the validation, should be working now. |
@padms - the script from http to https I understand. But when it comes to uppercase and lowercase letters in urls, I am more hesitant if we should change it and wonder what will happen in the future (after implementing this) - both for existing external urls and new ones we add that are copied from their "original place" and used containing both uppercase and lowercase letters. Editors will probably use the links as they are received from stakeholders (copy/paste). Will these external urls then give an error message editors will struggle to understand and need to be manually edited to only contain lowercase letters - as I did for the last link on this page (with real examples). |
@meols This error related to magazine page with tags is fixed now.. What has been done:
|
@padms - I'm still not sure about the upper/lower case issue. How critical is it to impplement that? As far as I remember it is related to a few short urls to avoid a redirect chain redirecting from uppercase to lowercase. |
@meols Both urls would be accepted with no doubt. Found this on google
|
@meols The error message "Equinor URLs should contain lower case letter only" appears for all equinor.com and satellite sites urls when the contain uppercase letters Urls like "https://www.equinor.com/magazine?tag=Our+energy+solutions" is allowed, as upper case letter after "?" is allowed and no redirect happens in such case. Other websites like "docmap.equinor.com" are treated as external websites and uppercase validation is not done. |
Thanks @padms - if you recommend to do this it's fine with me. One question to the error message where we get two messages for one error (http); could we remove the first one - "Does not match...." An editor (me included) wouldn't know what that one means. |
@meols I gave a fix to remove the extra error which is another way of saying "http is not allowed" :P |
Thanks @padms - approved 👍 |
* 🎨 add warning for http and not valid slug * 🐛 Refactor after comments #2496 * 🚨 Lint #2496 * 💚 🐛 Fix import bug #2496 * 🐛 Fix error with validation #2496 * 🐛 Check lowercase excluding queryparam #2496 * 🐛 Allow http to avoid error msg that confuses #2496 --------- Co-authored-by: Padmaja <[email protected]>
5 SEO benefits of 301 HTTP to HTTPS redirect:
Clear migration that helps Google understand all old URLs moved to new ones.
Google trusts a 301 migration as it sees it as one big relocation from HTTP to HTTPS.
Google perceives it as a normal generic site move and rankings aren’t negatively impacted.
HTTPS websites perform better on Google since they are beneficial to users by providing extra security.
301 redirects ensure a proper indexation of your website by Google.
The text was updated successfully, but these errors were encountered: