Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into image ratios #2513

Open
BorghildSelle opened this issue Sep 11, 2024 · 2 comments
Open

Look into image ratios #2513

BorghildSelle opened this issue Sep 11, 2024 · 2 comments
Assignees

Comments

@BorghildSelle
Copy link
Contributor

BorghildSelle commented Sep 11, 2024

in the ratios we have three_to_ten, which is then actually 3:10.
But we use it like 10:3, which should be written like ten_to_three.

Fix the that the images that should have three_to_ten(3:10) use the 3:10.
If some images should have 10:3, use ratio ten_to_three

Look into the images that should be 16:9/aspect-video to have sixteen_to_nine(16:9)

Look into which images should have 9:16(nine_to_sixteen)

Check that names and ratio matches

@VarunVAshrit VarunVAshrit self-assigned this Sep 13, 2024
@VarunVAshrit
Copy link
Collaborator

Consider the ratio three_to_ten which is 3:10 and the value will be 3/10 = 0.3. But if we consider "full width image" component, in the groq query it says 10:3 but in the component it is three_to_ten. Even in sanity it says { title: '10:3', value: 0.3 }, here if we use the same logic ten_to_three will be 10:3 and the value will be 10/3 = 3.333 but in sanity for the ratio 10:3 the value is 0.3.

@BorghildSelle
Copy link
Contributor Author

The ratios would have to be fixed in sanity as well then to reflect correct name to value, but it would require an migration script for production maybe, so we will put this back into the backlog for when we have more time on our hands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants