Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News template: if adding custom date when preparing an unpublished news article, the "status" shown is Published when it should be unpublished #2524

Closed
meols opened this issue Sep 16, 2024 · 6 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@meols
Copy link
Collaborator

meols commented Sep 16, 2024

Showing published "status" when the page is not yet published is confusing for editors and could potentially lead to someone publishing a confidential article because of a text update when it is still on hold.
image.png

@meols meols added the 🐛 bug Something isn't working label Sep 16, 2024
@meols meols changed the title News template: when adding a News template: if adding custom date when preparing an unpublished news article, the "status" shown is Published when it should be unpublished Sep 16, 2024
@meols
Copy link
Collaborator Author

meols commented Sep 16, 2024

I also see the same on dev
image.png

@meols
Copy link
Collaborator Author

meols commented Sep 25, 2024

@millianapia - I still see some issues with news and dates.

  • If I add a custom date for tomorrow by mistake, the text below title says Published date: Not published, while the mouseover says that it is published (1), and it is visible on the /news page with a published date tomorrow (26 Sept)
  • If I test publishing a different unpublished news, the publishing is "hanging" while the text change to Published date: 25 Sept 2024 (2). If I then assume it is published since the text changed to publish, and then refresh to stop the "hanging" after a few minutes, it turns out that it isn't published after all - even if it now has a published date (see video)
    So we have issues with news hanging when publishing (have seen it several times) and wonder if it shouldn't be possible to publish a page with a date in the future - unless it is set up with scheduling?

Private Zenhub Video

image.png

image.png

@meols
Copy link
Collaborator Author

meols commented Sep 26, 2024

Adding a video from today as well.
We would like to only have the date in custom date checked (not the time). We may prepare news and press publish a minute or two to have newsletters going out, and e.g. press publish at 11:58 but have 12:00 visible in the news as a "nice press release time" 😄
Could the validation text rather be:
Publication date and time
The date can’t be in the future

Private Zenhub Video

millianapia added a commit that referenced this issue Sep 26, 2024
@millianapia
Copy link
Contributor

adjustments has been made, so the time is ignored and only the date is compared @meols

@meols
Copy link
Collaborator Author

meols commented Sep 26, 2024

I just noticed that if i don't add a custom date I get a validation error
image.png

@meols
Copy link
Collaborator Author

meols commented Sep 27, 2024

@millianapia - today I also remembered that local new are also news 😉 and tested that - and there are some issues with local news and date also.
It says Published date: Ikke oppgitt (in Norwegian) for published pages. I think it is when custom date isn't used.
image.png

Private Zenhub Video

millianapia added a commit that referenced this issue Oct 9, 2024
* 🐛 Check for future date on published news #2524

* 🎨 Make date field required and date must be in the past #2524

* Adjustments to time logic #2524

* ♻️ Refactor for better readability and comments #2524

* 🐛  Adding missing fields and custom publication logic #2524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants