Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from OpenCensus to OpenTelemetry #510

Open
tsundvoll opened this issue Jan 9, 2024 · 2 comments
Open

Migrate from OpenCensus to OpenTelemetry #510

tsundvoll opened this issue Jan 9, 2024 · 2 comments
Assignees
Labels
improvement Improvement to existing functionality stale This issue or pull request already exists

Comments

@tsundvoll
Copy link
Contributor

Describe the improvement you would like to see
Migrate from OpenCensus to OpenTelemetry, as the former is deprecated.

Reference and migration guide: https://learn.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-python-opencensus-migrate?tabs=aspnetcore

How will this change existing functionality?
The functionality should be the same; i.e. telemetry and logs should still be sent to Application Insight.

How will this improvement affect the current Threat Model?
Will possibly improve the Threat Model, since the opencensus package seem to introduce a dependency on gcc that has some vulnerabilities.

"After July 31st, 2023, the OpenCensus project will no longer be maintained. This means that there will be no new features added to the project, and any security vulnerabilities that are found will not be patched." - https://opentelemetry.io/blog/2023/sunsetting-opencensus/

@tsundvoll tsundvoll added the improvement Improvement to existing functionality label Jan 9, 2024
@tsundvoll tsundvoll self-assigned this Jan 10, 2024
@tsundvoll
Copy link
Contributor Author

It seems like this SDK for Python is not quite mature yet. After some investigations and trials, I experienced it being slow to start the application, and sometimes not starting at all. When I Ctrl+C it looked like it was interrupted at some if lock.acquire(block, timeout) in a thread. Could be related to our threads, or something going on within the configure_azure_monitor() function (with and without arguments) which I tried to run at startup.

I also got Exception in detector <opentelemetry.resource.detector.azure.vm.AzureVMResourceDetector object at 0x1318b1e20>, ignoring and I could not find good explanations of this in the documentations / forums.

According to Microsoft (https://learn.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-python-opencensus-migrate?tabs=aspnetcore) they support the old OpenSensus SDK until September 30 2024.

I therefore suggest we postpone the migration to OpenTelemetry until the Python SDK is more mature and stable.

@tsundvoll tsundvoll reopened this Jan 22, 2024
@aeshub
Copy link
Contributor

aeshub commented May 3, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality stale This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants