Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize and MoveArm have the wrong baseclass #553

Open
Christdej opened this issue May 27, 2024 · 1 comment
Open

Localize and MoveArm have the wrong baseclass #553

Christdej opened this issue May 27, 2024 · 1 comment
Labels
good first issue Good for newcomers improvement Improvement to existing functionality stale This issue or pull request already exists

Comments

@Christdej
Copy link
Contributor

Christdej commented May 27, 2024

Describe the bug
@dataclass class MotionStep(Step): """ Base class for all steps which should move the robot, but not return a result. """

@dataclass class Localize(MotionStep): """ Step which causes the robot to localize """

@dataclass class MoveArm(MotionStep): """ Step which causes the robot to move its arm """

The Localize and MoveArm classes should not have MotionStep as they do not move the robot. The description for MotionStep could also be more precise in the description so it is clear that MotionStep should only include step that move the base of the robot
This would make it easier to use the base classes in the different robots too.

@Christdej Christdej added the bug Something isn't working label May 27, 2024
@tsundvoll tsundvoll added improvement Improvement to existing functionality and removed bug Something isn't working labels May 27, 2024
@andchiind andchiind added the good first issue Good for newcomers label Jul 17, 2024
@aeshub
Copy link
Contributor

aeshub commented Nov 3, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvement to existing functionality stale This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants