Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate removal of localize from ISAR #630

Open
Eddasol opened this issue Oct 21, 2024 · 0 comments · Fixed by #631
Open

Investigate removal of localize from ISAR #630

Eddasol opened this issue Oct 21, 2024 · 0 comments · Fixed by #631
Labels
improvement Improvement to existing functionality

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Oct 21, 2024 •
edited
Loading

Describe the improvement you would like to see
ISAR no longer sends Localize steps in full missions as this is expected to be handled by the specific robot package.

It might be possible to remove the Localize step and other localization related functionality from ISAR. Including the api endpoint for starting localization missions (might be enough to deprecate for now)

How will this change existing functionality?
This will remove unnecessary clutter and make the code more readable

How will this improvement affect the current Threat Model?
N/A
@Eddasol Eddasol added the improvement Improvement to existing functionality label Oct 21, 2024
@Eddasol Eddasol changed the title Remove localize from ISAR Investigate removal of localize from ISAR Oct 21, 2024
@Eddasol Eddasol linked a pull request Oct 21, 2024 that will close this issue
Deprecate start localization mission endpoint #631
Merged
@Eddasol Eddasol reopened this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate start localization mission endpoint Eddasol/isar
1 participant
@Eddasol