Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTORING]: groupTreeAssembler.js in GroupTreePlot #1829

Open
rubenthoms opened this issue Dec 12, 2023 · 1 comment
Open

[REFACTORING]: groupTreeAssembler.js in GroupTreePlot #1829

rubenthoms opened this issue Dec 12, 2023 · 1 comment
Assignees
Labels
bug Something isn't working CeeSol Task owned by Ceetron Solutions group-tree

Comments

@rubenthoms
Copy link
Collaborator

rubenthoms commented Dec 12, 2023

The drawing class in groupTreeAssembler.js utilized in GroupTreePlot does not support resizing. It does only use the initial width and height of the element it is rendered in and does not adjust to changes of the parent element. This can lead to bad UX, especially in the dynamic new Webviz application.

Recording 2023-12-12 111231 (1)

In addition, the class' code is difficult to adjust and maintain since it is written in plain JavaScript.

I suggest to:

  • Completely refactor/rewrite the drawing class in TypeScript
  • Add support for resizing
@rubenthoms rubenthoms self-assigned this Dec 12, 2023
@rubenthoms rubenthoms added bug Something isn't working CeeSol Task owned by Ceetron Solutions group-tree labels Dec 12, 2023
@jorgenherje
Copy link
Collaborator

jorgenherje commented Dec 12, 2023

When performing the initial splitting, I started looking into converting grup_tree.js to typescript. This work can pinpoint some of the issues detected when trying to purely convert the .js implementation into .ts. E.g. the existing .js code directly manipulates d3 objects used, by adding new attributes etc in code. This is not allowed when using typescript.

Here is the testing branch: https://github.com/CeetronSolutions/webviz-subsurface-components/tree/split-group-tree-setting-and-view-ts-conversion-backup

Initial converting GroupTree.ts: https://github.com/CeetronSolutions/webviz-subsurface-components/blob/split-group-tree-setting-and-view-ts-conversion-backup/typescript/packages/group-tree/src/components/group-tree-plot/src/Plot/GroupTree.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CeeSol Task owned by Ceetron Solutions group-tree
Projects
None yet
Development

No branches or pull requests

3 participants