Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of pure python and possibly remove engine arguments in surface import/export #1243

Open
jcrivenaes opened this issue Sep 9, 2024 · 0 comments
Labels
enhancement New feature or request refactor Code improvements (~invisible for users)

Comments

@jcrivenaes
Copy link
Collaborator

The import and export of surfaces has in many cases two option w.r.t. "engine", e.g.

surf1 = xtgeo.surface_from_file("myfile.gri", engine="cxtgeo")   # default is currently cxtgeo
surf1 = xtgeo.surface_from_file("myfile.gri", engine="python")   # default only when using memstreams

The result should be identical. The default option cxtgeo (using C compiled bindings) is default to
a) historical reasons
b) it is tested to be faster.

However, offline tests I have done shows that optimizing the python code can give speed as fast as the C code.

It may also be that some observed instability in tests, in particular when doing forks (see #1229) could
be related to the cxtgeo C bindings.

Propose therefore to simplify code, and run only with only python code if possible. The engine option should not produce
different outcome, so it can be removed/inactivated possibly without any side-effects.

@jcrivenaes jcrivenaes added enhancement New feature or request refactor Code improvements (~invisible for users) labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Code improvements (~invisible for users)
Projects
None yet
Development

No branches or pull requests

1 participant